Remove hack only needed for old version of Visual Studio

NathanJPhillips · NathanJPhillips · commit 754eba5de028 · 2019-05-23T14:18:00.000+01:00
diff --git a/jbmc/src/java_bytecode/jar_pool.cpp b/jbmc/src/java_bytecode/jar_pool.cpp
@@ -13,11 +13,7 @@ jar_filet &jar_poolt::operator()(const std::string &file_name)
 {
   const auto it = m_archives.find(file_name);
   if(it == m_archives.end())
-  {
-    // VS: Can't construct in place
-    auto file = jar_filet(file_name);
-    return m_archives.emplace(file_name, std::move(file)).first->second;
-  }
+    return m_archives.emplace(file_name, jar_filet(file_name)).first->second;
   else
     return it->second;
 }

Original file line number	Diff line number	Diff line change
`@@ -13,11 +13,7 @@ jar_filet &jar_poolt::operator()(const std::string &file_name)`
`13`	`13`	`{`
`14`	`14`	`const auto it = m_archives.find(file_name);`
`15`	`15`	`if(it == m_archives.end())`
`16`		`- {`
`17`		`- // VS: Can't construct in place`
`18`		`- auto file = jar_filet(file_name);`
`19`		`- return m_archives.emplace(file_name, std::move(file)).first->second;`
`20`		`- }`
	`16`	`+ return m_archives.emplace(file_name, jar_filet(file_name)).first->second;`
`21`	`17`	`else`
`22`	`18`	`return it->second;`
`23`	`19`	`}`