Skip to content

Commit 6db9447

Browse files
committed
Improve coverage of incr-oneloop traces
by adding a test for the standard trace and comment out the non-standard ones for now.
1 parent 07e3177 commit 6db9447

File tree

2 files changed

+30
-13
lines changed

2 files changed

+30
-13
lines changed
Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
CORE
2+
main.c
3+
--incremental-loop main.0 --unwind-min 5 --unwind-max 10 --trace
4+
^EXIT=10$
5+
^SIGNAL=0$
6+
^VERIFICATION FAILED$
7+
^State \d+ file main.c function havocIO line 501 thread \d+$
8+
--
9+
^warning: ignoring

src/goto-checker/single_loop_incremental_symex_checker.cpp

Lines changed: 21 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -168,25 +168,33 @@ operator()(propertiest &properties)
168168

169169
goto_tracet single_loop_incremental_symex_checkert::build_full_trace() const
170170
{
171-
goto_tracet goto_trace;
172-
build_goto_trace(
173-
equation,
174-
equation.SSA_steps.end(),
175-
property_decider.get_decision_procedure(),
176-
ns,
177-
goto_trace);
178-
179-
return goto_trace;
171+
UNREACHABLE;
172+
// When needed un-comment the implementation below, right now `cover` and
173+
// `paths` are incompatible.
174+
//
175+
// goto_tracet goto_trace;
176+
// build_goto_trace(
177+
// equation,
178+
// equation.SSA_steps.end(),
179+
// property_decider.get_decision_procedure(),
180+
// ns,
181+
// goto_trace);
182+
183+
// return goto_trace;
180184
}
181185

182186
goto_tracet single_loop_incremental_symex_checkert::build_shortest_trace() const
183187
{
184188
if(options.get_bool_option("beautify"))
185189
{
186-
// NOLINTNEXTLINE(whitespace/braces)
187-
counterexample_beautificationt{ui_message_handler}(
188-
dynamic_cast<boolbvt &>(property_decider.get_stack_decision_procedure()),
189-
equation);
190+
UNREACHABLE;
191+
// For now, beautification and incremental are incompatible.
192+
//
193+
// auto &decision_procedure = dynamic_cast<boolbvt &>(
194+
// property_decider.get_stack_decision_procedure());
195+
// auto counterexample_beautification =
196+
// counterexample_beautificationt{ui_message_handler};
197+
// counterexample_beautification(decision_procedure, equation);
190198
}
191199

192200
goto_tracet goto_trace;

0 commit comments

Comments
 (0)