Add unit test for inner class names

Added because it is good to test new features.

Author: thomasspriggs

jbmc/unit/Makefile

@@ -38,6 +38,7 @@ SRC += java_bytecode/ci_lazy_methods/lazy_load_lambdas.cpp \
        java_bytecode/java_bytecode_parse_lambdas/java_bytecode_convert_class_lambda_method_handles.cpp \
        java_bytecode/java_bytecode_parse_lambdas/java_bytecode_parse_lambda_method_table.cpp \
        java_bytecode/java_bytecode_parser/parse_class_without_instructions.cpp \
+       java_bytecode/java_bytecode_parser/parse_inner_class.cpp \
        java_bytecode/java_bytecode_parser/parse_java_annotations.cpp \
        java_bytecode/java_bytecode_parser/parse_java_attributes.cpp \
        java_bytecode/java_bytecode_parser/parse_java_class.cpp \

jbmc/unit/java_bytecode/java_bytecode_parser/Outer$1.class

@@ -0,0 +1,2 @@
+class Outer$RedHerring {
+}

jbmc/unit/java_bytecode/java_bytecode_parser/Outer$Inner.class

@@ -0,0 +1,7 @@
+class Outer {
+  class Inner {
+  }
+
+  Outer anonymous = new Outer() {
+  };
+}

jbmc/unit/java_bytecode/java_bytecode_parser/Outer$RedHerring.class

@@ -0,0 +1,121 @@
+/*******************************************************************\
+
+ Module: Unit tests for converting inner classes
+
+ Author: Diffblue Ltd.
+
+\*******************************************************************/
+
+#include <java-testing-utils/load_java_class.h>
+#include <java_bytecode/java_types.h>
+#include <testing-utils/catch.hpp>
+
+SCENARIO(
+  "Parsing inner java classes",
+  "[core][java_bytecode][java_bytecode_convert_class]")
+{
+  GIVEN("A class file of an inner class.")
+  {
+    WHEN("Parsing an inner class called \"Inner\".")
+    {
+      const symbol_tablet &symbol_table = load_java_class(
+        "Outer$Inner", "./java_bytecode/java_bytecode_convert_class");
+      const symbolt *class_symbol = symbol_table.lookup("java::Outer$Inner");
+      REQUIRE(class_symbol);
+      const java_class_typet *class_type =
+        type_try_dynamic_cast<java_class_typet>(class_symbol->type);
+      REQUIRE(class_type);
+
+      THEN("The inner class should have the inner name \"Inner\".")
+      {
+        REQUIRE(id2string(class_type->get_inner_name()) == "Inner");
+      }
+      THEN("The inner class is not considered to be an anonymous class.")
+      {
+        REQUIRE_FALSE(class_type->get_is_anonymous_class());
+      }
+      THEN("The inner class has the outer class \"Outer\".")
+      {
+        REQUIRE(id2string(class_type->get_outer_class()) == "Outer");
+      }
+    }
+  }
+  GIVEN("A class file of a class which is not an inner class.")
+  {
+    WHEN("Parsing an outer class.")
+    {
+      const symbol_tablet &symbol_table =
+        load_java_class("Outer", "./java_bytecode/java_bytecode_convert_class");
+      const symbolt *class_symbol = symbol_table.lookup("java::Outer");
+      REQUIRE(class_symbol);
+      const java_class_typet *class_type =
+        type_try_dynamic_cast<java_class_typet>(class_symbol->type);
+      REQUIRE(class_type);
+
+      THEN("The outer class should not have an inner name.")
+      {
+        REQUIRE(id2string(class_type->get_inner_name()).empty());
+      }
+      THEN("The outer class is not considered to be an anonymous class.")
+      {
+        REQUIRE_FALSE(class_type->get_is_anonymous_class());
+      }
+      THEN("The outer class does not have an outer class.")
+      {
+        REQUIRE(id2string(class_type->get_outer_class()).empty());
+      }
+    }
+  }
+  GIVEN("A class file of an anonymous class.")
+  {
+    WHEN("Parsing an anonymous class.")
+    {
+      const symbol_tablet &symbol_table = load_java_class(
+        "Outer$1", "./java_bytecode/java_bytecode_convert_class");
+      const symbolt *class_symbol = symbol_table.lookup("java::Outer$1");
+      REQUIRE(class_symbol);
+      const java_class_typet *class_type =
+        type_try_dynamic_cast<java_class_typet>(class_symbol->type);
+      REQUIRE(class_type);
+
+      THEN("The anonymous class should not have an inner name.")
+      {
+        REQUIRE(id2string(class_type->get_inner_name()).empty());
+      }
+      THEN("The anonymous class is considered to be an anonymous class.")
+      {
+        REQUIRE(class_type->get_is_anonymous_class());
+      }
+      THEN("The anonymous class does not have an outer class.")
+      {
+        REQUIRE(id2string(class_type->get_outer_class()).empty());
+      }
+    }
+  }
+  GIVEN("A class file of an outer class which is named with a '$'.")
+  {
+    WHEN("Parsing an outer class named with a '$'.")
+    {
+      const symbol_tablet &symbol_table = load_java_class(
+        "Outer$RedHerring", "./java_bytecode/java_bytecode_convert_class");
+      const auto *class_symbol = symbol_table.lookup("java::Outer$RedHerring");
+      REQUIRE(class_symbol);
+      const java_class_typet *class_type =
+        type_try_dynamic_cast<java_class_typet>(class_symbol->type);
+      REQUIRE(class_type);
+
+      THEN("The outer class should not have an inner name.")
+      {
+        REQUIRE(id2string(class_type->get_inner_name()).empty());
+      }
+      THEN("The inner class is not considered to be an anonymous class.")
+      {
+        REQUIRE_FALSE(class_type->get_is_anonymous_class());
+      }
+      THEN("The outer class does not have an outer class.")
+      {
+        REQUIRE(id2string(class_type->get_outer_class()).empty());
+      }
+    }
+  }
+}