Replace the use of cmdline with options in goto-analyzer and goto-diff

This uncovered a bug in goto-analyzer where the options for goto-check
are recognised but not actually parsed.

Author: martin

src/goto-analyzer/goto_analyzer_parse_options.cpp

@@ -146,6 +146,9 @@ void goto_analyzer_parse_optionst::get_command_line_options(optionst &options)
     options.set_option("error-label", cmdline.get_values("error-label"));
 #endif
 
+  // all checks supported by goto_check
+  PARSE_OPTIONS_GOTO_CHECK(cmdline, options);
+
   // The user should either select:
   //  1. a specific analysis, or
   //  2. a tuple of task / analyser options / outputs
@@ -893,7 +896,7 @@ bool goto_analyzer_parse_optionst::process_goto_program(
     log.status() << "Removing function pointers and virtual functions"
                  << messaget::eom;
     remove_function_pointers(
-      ui_message_handler, goto_model, cmdline.isset("pointer-check"));
+      ui_message_handler, goto_model, options.get_bool_option("pointer-check"));
 
     // do partial inlining
     log.status() << "Partial Inlining" << messaget::eom;

src/goto-diff/goto_diff_parse_options.cpp

@@ -340,7 +340,7 @@ bool goto_diff_parse_optionst::process_goto_program(
     log.status() << "Removal of function pointers and virtual functions"
                  << messaget::eom;
     remove_function_pointers(
-      ui_message_handler, goto_model, cmdline.isset("pointer-check"));
+      ui_message_handler, goto_model, options.get_bool_option("pointer-check"));
 
     mm_io(goto_model);