Skip to content

Commit 64c1757

Browse files
author
martin
committed
Move the handling of C/C++ standard versions into configt
Although configt is not an ideal solution, I think it is best for it to do all of the parsing for its option in one place. As a side effect this adds the C and C++ language options to goto-analyzer.
1 parent d8b71f5 commit 64c1757

File tree

4 files changed

+18
-56
lines changed

4 files changed

+18
-56
lines changed

src/cbmc/cbmc_parse_options.cpp

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -203,9 +203,6 @@ void cbmc_parse_optionst::get_command_line_options(optionst &options)
203203
if(cmdline.isset("mm"))
204204
options.set_option("mm", cmdline.get_value("mm"));
205205

206-
if(cmdline.isset("c89"))
207-
config.ansi_c.set_c89();
208-
209206
if(cmdline.isset("symex-complexity-limit"))
210207
options.set_option(
211208
"symex-complexity-limit", cmdline.get_value("symex-complexity-limit"));
@@ -215,21 +212,6 @@ void cbmc_parse_optionst::get_command_line_options(optionst &options)
215212
"symex-complexity-failed-child-loops-limit",
216213
cmdline.get_value("symex-complexity-failed-child-loops-limit"));
217214

218-
if(cmdline.isset("c99"))
219-
config.ansi_c.set_c99();
220-
221-
if(cmdline.isset("c11"))
222-
config.ansi_c.set_c11();
223-
224-
if(cmdline.isset("cpp98"))
225-
config.cpp.set_cpp98();
226-
227-
if(cmdline.isset("cpp03"))
228-
config.cpp.set_cpp03();
229-
230-
if(cmdline.isset("cpp11"))
231-
config.cpp.set_cpp11();
232-
233215
if(cmdline.isset("property"))
234216
options.set_option("property", cmdline.get_values("property"));
235217

src/goto-analyzer/goto_analyzer_parse_options.cpp

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -101,26 +101,6 @@ void goto_analyzer_parse_optionst::get_command_line_options(optionst &options)
101101
if(cmdline.isset("function"))
102102
options.set_option("function", cmdline.get_value("function"));
103103

104-
#if 0
105-
if(cmdline.isset("c89"))
106-
config.ansi_c.set_c89();
107-
108-
if(cmdline.isset("c99"))
109-
config.ansi_c.set_c99();
110-
111-
if(cmdline.isset("c11"))
112-
config.ansi_c.set_c11();
113-
114-
if(cmdline.isset("cpp98"))
115-
config.cpp.set_cpp98();
116-
117-
if(cmdline.isset("cpp03"))
118-
config.cpp.set_cpp03();
119-
120-
if(cmdline.isset("cpp11"))
121-
config.cpp.set_cpp11();
122-
#endif
123-
124104
// all checks supported by goto_check
125105
PARSE_OPTIONS_GOTO_CHECK(cmdline, options);
126106

src/goto-diff/goto_diff_parse_options.cpp

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -97,24 +97,6 @@ void goto_diff_parse_optionst::get_command_line_options(optionst &options)
9797
if(cmdline.isset("mm"))
9898
options.set_option("mm", cmdline.get_value("mm"));
9999

100-
if(cmdline.isset("c89"))
101-
config.ansi_c.set_c89();
102-
103-
if(cmdline.isset("c99"))
104-
config.ansi_c.set_c99();
105-
106-
if(cmdline.isset("c11"))
107-
config.ansi_c.set_c11();
108-
109-
if(cmdline.isset("cpp98"))
110-
config.cpp.set_cpp98();
111-
112-
if(cmdline.isset("cpp03"))
113-
config.cpp.set_cpp03();
114-
115-
if(cmdline.isset("cpp11"))
116-
config.cpp.set_cpp11();
117-
118100
// all checks supported by goto_check
119101
PARSE_OPTIONS_GOTO_CHECK(cmdline, options);
120102

src/util/config.cpp

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1127,6 +1127,24 @@ bool configt::set(const cmdlinet &cmdline)
11271127

11281128
ansi_c.malloc_may_fail = cmdline.isset("malloc-may-fail");
11291129

1130+
if(cmdline.isset("c89"))
1131+
ansi_c.set_c89();
1132+
1133+
if(cmdline.isset("c99"))
1134+
ansi_c.set_c99();
1135+
1136+
if(cmdline.isset("c11"))
1137+
ansi_c.set_c11();
1138+
1139+
if(cmdline.isset("cpp98"))
1140+
cpp.set_cpp98();
1141+
1142+
if(cmdline.isset("cpp03"))
1143+
cpp.set_cpp03();
1144+
1145+
if(cmdline.isset("cpp11"))
1146+
cpp.set_cpp11();
1147+
11301148
return false;
11311149
}
11321150

0 commit comments

Comments
 (0)