Skip to content

Commit 629ba0f

Browse files
committed
read_graphml: use a proper message handler
Using null_message_handlert may hide errors.
1 parent 31e4ddf commit 629ba0f

File tree

2 files changed

+10
-6
lines changed

2 files changed

+10
-6
lines changed

src/xmllang/graphml.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -177,9 +177,9 @@ static bool build_graph(
177177
bool read_graphml(
178178
std::istream &is,
179179
graphmlt &dest,
180-
graphmlt::node_indext &entry)
180+
graphmlt::node_indext &entry,
181+
message_handlert &message_handler)
181182
{
182-
null_message_handlert message_handler;
183183
xmlt xml;
184184

185185
if(parse_xml(is, "", message_handler, xml))
@@ -191,9 +191,9 @@ bool read_graphml(
191191
bool read_graphml(
192192
const std::string &filename,
193193
graphmlt &dest,
194-
graphmlt::node_indext &entry)
194+
graphmlt::node_indext &entry,
195+
message_handlert &message_handler)
195196
{
196-
null_message_handlert message_handler;
197197
xmlt xml;
198198

199199
if(parse_xml(filename, message_handler, xml))

src/xmllang/graphml.h

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,8 @@ Author: Michael Tautschnig, [email protected]
1919
#include <util/graph.h>
2020
#include <util/xml.h>
2121

22+
class message_handlert;
23+
2224
struct xml_edget
2325
{
2426
xmlt xml_node;
@@ -68,11 +70,13 @@ class graphmlt:public grapht<xml_graph_nodet>
6870
bool read_graphml(
6971
std::istream &is,
7072
graphmlt &dest,
71-
graphmlt::node_indext &entry);
73+
graphmlt::node_indext &entry,
74+
message_handlert &message_handler);
7275
bool read_graphml(
7376
const std::string &filename,
7477
graphmlt &dest,
75-
graphmlt::node_indext &entry);
78+
graphmlt::node_indext &entry,
79+
message_handlert &message_handler);
7680

7781
bool write_graphml(const graphmlt &src, std::ostream &os);
7882

0 commit comments

Comments
 (0)