Skip to content

Commit 57be244

Browse files
Remove comment made unecessary
Now the log field gets initialized before parse_options_baset is constructed so there is no danger as described in the comment.
1 parent b637eea commit 57be244

File tree

1 file changed

+0
-12
lines changed

1 file changed

+0
-12
lines changed

src/util/parse_options.cpp

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -36,18 +36,6 @@ parse_options_baset::parse_options_baset(
3636
ui_message_handler(cmdline, program),
3737
log(ui_message_handler)
3838
{
39-
40-
// DO NOT USE log HERE!
41-
//
42-
// The usual pattern of use is that the application class inherits from
43-
// messaget and parse_options_baset using a member variable of type
44-
// message_handlert to construct the messaget part.
45-
//
46-
// C++'s rules of initialisation mean that the constructors for
47-
// messaget and then parse_options_base run before those of message_handlert.
48-
// This means that the message_handlert object is uninitialised.
49-
// Using it here will likely cause a hard to debug failure somewhere in
50-
// the messaget code.
5139
}
5240

5341
void parse_options_baset::help()

0 commit comments

Comments
 (0)