Add error test and fix error message

This commit adds a test of input error and also makes the
error message consistent.

Author: TGWDB

regression/cbmc/enum_is_in_range/enum_test12.c

@@ -0,0 +1,20 @@
+#include <assert.h>
+
+enum my_enum
+{
+  first,
+  second,
+  third,
+  fourth,
+  fifth
+};
+
+int main()
+{
+  enum my_enum ev1;
+  enum my_enum ev2;
+  ev1 = first;
+  ev2 = fifth;
+  assert(__CPROVER_enum_is_in_range(ev1, ev2));
+  return 0;
+}

regression/cbmc/enum_is_in_range/enum_test12.desc

@@ -0,0 +1,12 @@
+CORE
+enum_test12.c
+
+^EXIT=6$
+^SIGNAL=0$
+^file enum_test12.c line \d+ function main: __CPROVER_enum_is_in_range expects 1 argument, 2 were provided$
+--
+^\[main.assertion.1\] line \d+ assertion __CPROVER_enum_is_in_range\(.*\): SUCCESS$
+^\[main.assertion.1\] line \d+ assertion __CPROVER_enum_is_in_range\(.*\): FAILURE$
+^\*\*\*\* WARNING: no body for function __CPROVER_enum_is_in_range$
+--
+This test the type checking of argument for __CPROVER_num_is_in_range

src/ansi-c/c_typecheck_expr.cpp

@@ -2847,7 +2847,7 @@ exprt c_typecheck_baset::do_special_functions(
     if(expr.arguments().size() != 1)
     {
       error().source_location = expr.source_location();
-      error() << identifier << " expects one argument, "
+      error() << identifier << " expects 1 argument, "
               << expr.arguments().size() << " were provided" << eom;
       throw 0;
     }
@@ -2866,8 +2866,8 @@ exprt c_typecheck_baset::do_special_functions(
       std::vector<exprt> disjuncts;
       for(const auto &enum_value : enum_values)
       {
-        const constant_exprt val{enum_value.get_value(), *c_enum_tag_type};
-        disjuncts.push_back(equal_exprt(arg1, val));
+        constant_exprt val{enum_value.get_value(), *c_enum_tag_type};
+        disjuncts.push_back(equal_exprt(arg1, std::move(val)));
       }
 
       return disjunction(disjuncts);