Revert "strengthen assignment type consistency"

smowton · smowton · commit 555ff9aa08ca · 2019-01-14T15:50:33.000Z
This reverts commit caae4ce. Reverting because we can't currently meet either the weak (base_type_eq) or the strong (==) consistency requirement. Let's target the weak one first.
diff --git a/src/util/std_code.h b/src/util/std_code.h
@@ -303,7 +303,7 @@ class code_assignt:public codet
 
     DATA_CHECK(
       vm,
-      code.op0().type() == code.op1().type(),
+      base_type_eq(code.op0().type(), code.op1().type(), ns),
       "lhs and rhs of assignment must have same type");
   }
 

Original file line number	Diff line number	Diff line change
`@@ -303,7 +303,7 @@ class code_assignt:public codet`
`303`	`303`
`304`	`304`	`DATA_CHECK(`
`305`	`305`	`vm,`
`306`		`- code.op0().type() == code.op1().type(),`
	`306`	`+ base_type_eq(code.op0().type(), code.op1().type(), ns),`
`307`	`307`	`"lhs and rhs of assignment must have same type");`
`308`	`308`	`}`
`309`	`309`