Store identifiers of parameters in goto_functiont::parameter_identifiers

This is to enable a transition towards #4167.

Author: Daniel Kroening

src/goto-programs/goto_convert_functions.cpp

@@ -153,6 +153,13 @@ void goto_convert_functionst::convert_function(
 
   f.type=to_code_type(symbol.type);
 
+  // store the parameter identifiers in the goto functions
+  const code_typet &code_type = to_code_type(symbol.type);
+  f.parameter_identifiers.clear();
+  f.parameter_identifiers.reserve(code_type.parameters().size());
+  for(const auto &parameter : code_type.parameters())
+    f.parameter_identifiers.push_back(parameter.get_identifier());
+
   if(symbol.value.is_nil() ||
      symbol.is_compiled()) /* goto_inline may have removed the body */
     return;

src/goto-programs/goto_function.h

@@ -29,33 +29,35 @@ class goto_functiont
   goto_programt body;
 
   /// The type of the function, indicating the return type and parameter types
+  /// This is deprecated; get the type from the namespace instead.
   code_typet type;
 
   typedef std::vector<irep_idt> parameter_identifierst;
 
   /// The identifiers of the parameters of this function
   ///
-  /// Note: This variable is currently unused and the vector is thus always
-  /// empty. In the future the code base may be refactored to fill in the
-  /// parameter identifiers here when creating a `goto_functiont`. For now the
-  /// parameter identifiers should be retrieved from the type (`code_typet`).
+  /// Note: This is now the preferred way of getting the identifiers of the
+  /// parameters. The identifiers in the type will go away.
   parameter_identifierst parameter_identifiers;
 
   bool body_available() const
   {
     return !body.instructions.empty();
   }
 
+  /// This is deprecated; get the type from the namespace instead.
   bool is_inlined() const
   {
     return type.get_bool(ID_C_inlined);
   }
 
+  /// This is deprecated; get the type from the namespace instead.
   bool is_hidden() const
   {
     return type.get_bool(ID_C_hide);
   }
 
+  /// This is deprecated; modify the type in the namespace instead.
   void make_hidden()
   {
     type.set(ID_C_hide, true);