Merge pull request #4833 from peterschrammel/number-range-error-test

Handle missing lower bound in number range

Author: peterschrammel

src/util/format_number_range.cpp

@@ -134,6 +134,11 @@ std::vector<unsigned> parse_number_range(const std::string &number_range)
     }
     else if(c == '-')
     {
+      if(!number.has_value())
+      {
+        throw deserialization_exceptiont(
+          "lower bound missing in number range '" + number_range + "'");
+      }
       begin_range = number;
       number = {};
     }

unit/util/format_number_range.cpp

@@ -65,6 +65,7 @@ TEST_CASE(
   REQUIRE_THROWS_AS(parse_number_range(""), deserialization_exceptiont);
   REQUIRE_THROWS_AS(parse_number_range(","), deserialization_exceptiont);
   REQUIRE_THROWS_AS(parse_number_range("1,"), deserialization_exceptiont);
+  REQUIRE_THROWS_AS(parse_number_range("-5"), deserialization_exceptiont);
   REQUIRE_THROWS_AS(parse_number_range("0,1-"), deserialization_exceptiont);
   REQUIRE_THROWS_AS(parse_number_range("1, 2"), deserialization_exceptiont);
   REQUIRE_THROWS_AS(parse_number_range("4-2"), deserialization_exceptiont);