GitHub actions: Make all Windows checks consistent

With the exceptions of whether or not to create packages, run tests, or
do signing, make all three Windows configurations exactly the same.
Apart from cleanliness, the main benefit is the use of clcache for all
Windows build jobs, making them consistently faster:
check-vs-2019-build-and-test now completes after 36 minutes instead of
74 minutes.

Author: tautschnig

.github/workflows/pull-request-checks.yaml

@@ -175,29 +175,41 @@ jobs:
   check-vs-2019-build-and-test:
     runs-on: windows-2019
     env:
-      SCRIPT_DIR: .github/workflows/vs2019
+      GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
     steps:
-      - name: Checkout the repository
-        uses: actions/checkout@v2
+      - uses: actions/checkout@v2
         with:
-          submodules: recursive
-
-      - name: Install bison and flex
-        run: "${{env.SCRIPT_DIR}}\\install-bison.bat"
-
-      - name: Install z3
+          submodules: true
+      - name: Fetch dependencies
         run: |
-          Invoke-WebRequest "https://github.com/Z3Prover/z3/releases/download/z3-4.8.8/z3-4.8.8-x64-win.zip" -OutFile z3.zip
-          Expand-Archive z3.zip
-          # We need Get-ChildItem.Name here because the path includes
-          # the z3 version number, which we expect to change.
-          echo "$(Get-Location)\z3\$((Get-ChildItem z3).Name)" >> $env:GITHUB_PATH
-
-      - name: Build cbmc
-        run: "${{env.SCRIPT_DIR}}\\build-cbmc.bat"
-
+          choco install winflexbison3
+          nuget install clcache -OutputDirectory "c:\tools" -ExcludeVersion -Version 4.1.0
+          echo "c:\tools\clcache\clcache-4.1.0" >> $env:GITHUB_PATH
+      - name: Setup Visual Studio environment
+        uses: microsoft/[email protected]
+      - name: Prepare ccache
+        uses: actions/cache@v2
+        with:
+          path: .ccache
+          key: ${{ runner.os }}-msbuild-${{ github.ref }}-${{ github.sha }}
+          restore-keys: |
+            ${{ runner.os }}-msbuild-${{ github.ref }}
+            ${{ runner.os }}-msbuild
+      - name: ccache environment
+        run: |
+          echo "CLCACHE_BASEDIR=$((Get-Item -Path '.\').FullName)" >> $env:GITHUB_ENV
+          echo "CLCACHE_DIR=$pwd\.ccache" >> $env:GITHUB_ENV
+      - name: Configure with cmake
+        run: cmake -S . -B build
+      - name: Build Release
+        run: cmake --build build --config Release -- /p:UseMultiToolTask=true /p:CLToolExe=clcache
+      - name: Print ccache stats
+        run: clcache -s
+      - uses: ilammy/[email protected]
       - name: Test cbmc
-        run: "${{env.SCRIPT_DIR}}\\run-tests.bat"
+        run: |
+          Set-Location build
+          ctest -V -L CORE -C Release . -j2
 
   check-clang-format:
     runs-on: ubuntu-20.04
@@ -239,21 +251,21 @@ jobs:
           MERGE_BRANCH: ${{ github.ref }}
         run: ./.github/workflows/pull-request-check-cpplint.sh
 
-  # I just added this to check if my stuff is working on github actions
   windows-msi-package:
     runs-on: windows-2019
     env:
       GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
     steps:
       - uses: actions/checkout@v2
         with:
-          submodules: recursive
+          submodules: true
       - name: Fetch dependencies
         run: |
           choco install winflexbison3
           nuget install clcache -OutputDirectory "c:\tools" -ExcludeVersion -Version 4.1.0
           echo "c:\tools\clcache\clcache-4.1.0" >> $env:GITHUB_PATH
-      - uses: microsoft/[email protected]
+      - name: Setup Visual Studio environment
+        uses: microsoft/[email protected]
       - name: Prepare ccache
         uses: actions/cache@v2
         with:
@@ -267,14 +279,9 @@ jobs:
           echo "CLCACHE_BASEDIR=$((Get-Item -Path '.\').FullName)" >> $env:GITHUB_ENV
           echo "CLCACHE_DIR=$pwd\.ccache" >> $env:GITHUB_ENV
       - name: Configure with cmake
-        run: |
-          New-Item -ItemType Directory -Path build
-          Set-Location build
-          cmake ..
+        run: cmake -S . -B build
       - name: Build Release
-        run: |
-          Set-Location build
-          cmake --build . --config Release -- /p:UseMultiToolTask=true /p:CLToolExe=clcache
+        run: cmake --build build --config Release -- /p:UseMultiToolTask=true /p:CLToolExe=clcache
       - name: Print ccache stats
         run: clcache -s
       - name: Create packages

.github/workflows/release-packages.yaml

@@ -138,16 +138,16 @@ jobs:
     steps:
       - uses: actions/checkout@v2
         with:
-          submodules: recursive
+          submodules: true
       - name: Fetch dependencies
         run: |
           choco install winflexbison3
           nuget install clcache -OutputDirectory "c:\tools" -ExcludeVersion -Version 4.1.0
           echo "c:\tools\clcache\clcache-4.1.0" >> $env:GITHUB_PATH
-      - uses: microsoft/[email protected]
-        name: Setup Visual Studio environment
+      - name: Setup Visual Studio environment
+        uses: microsoft/[email protected]
       - name: Setup code sign environment
-        run: | 
+        run: |
           echo "$(Split-Path -Path $(Get-ChildItem -Path ${env:ProgramFiles(x86)} -Recurse -Filter 'signtool.exe' | Where-Object FullName -like '*10.0.19041.0\x64\signtool.exe').FullName)" >> $env:GITHUB_PATH
           echo "pfxcert=$([string](Get-Location)+'\CodeSignCertificate.pfx')" >> $env:GITHUB_ENV
       - name: Prepare ccache
@@ -163,18 +163,15 @@ jobs:
           echo "CLCACHE_BASEDIR=$((Get-Item -Path '.\').FullName)" >> $env:GITHUB_ENV
           echo "CLCACHE_DIR=$pwd\.ccache" >> $env:GITHUB_ENV
       - name: Configure with cmake
-        run: |
-          New-Item -ItemType Directory -Path build
-          Set-Location build
-          cmake ..
+        run: cmake -S . -B build
       - name: Build Release
-        run: |
-          Set-Location build
-          cmake --build . --config Release -- /p:UseMultiToolTask=true /p:CLToolExe=clcache
+        run: cmake --build build --config Release -- /p:UseMultiToolTask=true /p:CLToolExe=clcache
       - name: Print ccache stats
         run: clcache -s
       - name: Create packages
         id: create_packages
+        # We need to get the path to cpack because fascinatingly,
+        # chocolatey also includes a command called "cpack" which takes precedence
         run: |
           Set-Location build
           $cpack = "$(Split-Path -Parent (Get-Command cmake).Source)\cpack.exe"