Skip to content

Commit 524ca1c

Browse files
committed
PR requested changes
1 parent 69a7088 commit 524ca1c

File tree

1 file changed

+4
-5
lines changed

1 file changed

+4
-5
lines changed

src/util/graph.h

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -253,7 +253,7 @@ class grapht
253253
get_reachable(const std::vector<node_indext> &src, bool forwards) const;
254254

255255
void disconnect_unreachable(node_indext src);
256-
void disconnect_unreachable(std::vector<node_indext> src);
256+
void disconnect_unreachable(const std::vector<node_indext> &src);
257257

258258
void make_chordal();
259259

@@ -475,16 +475,15 @@ void grapht<N>::visit_reachable(node_indext src)
475475
template <class N>
476476
void grapht<N>::disconnect_unreachable(node_indext src)
477477
{
478-
std::vector<node_indext> source_nodes;
479-
source_nodes.push_back(src);
478+
const std::vector<node_indext> source_nodes(1, src);
480479
disconnect_unreachable(source_nodes);
481480
}
482481

483482
/// Removes any edges between nodes in a graph that are unreachable
484483
/// from a vector of start nodes.
485484
/// \param src: vector of indices of start nodes
486485
template <class N>
487-
void grapht<N>::disconnect_unreachable(std::vector<node_indext> src)
486+
void grapht<N>::disconnect_unreachable(const std::vector<node_indext> &src)
488487
{
489488
std::vector<node_indext> reachable = get_reachable(src, true);
490489
std::sort(reachable.begin(), reachable.end());
@@ -493,7 +492,7 @@ void grapht<N>::disconnect_unreachable(std::vector<node_indext> src)
493492
{
494493
if(reachable_idx >= reachable.size())
495494
return;
496-
PRECONDITION(i <= reachable[reachable_idx]);
495+
497496
if(i > reachable[reachable_idx])
498497
throw "error disconnecting unreachable nodes";
499498

0 commit comments

Comments
 (0)