Get_all_property_ids should only return failed properties

Passed properties on traces are less interesting.

Author: peterschrammel

src/goto-programs/goto_trace.cpp

@@ -778,7 +778,7 @@ std::vector<irep_idt> goto_tracet::get_all_property_ids() const
   std::vector<irep_idt> property_ids;
   for(const auto &step : steps)
   {
-    if(step.is_assert())
+    if(step.is_assert() && !step.cond_value)
       property_ids.push_back(step.property_id);
   }
   return property_ids;

src/goto-programs/goto_trace.h

@@ -201,7 +201,7 @@ class goto_tracet
     return steps.back();
   }
 
-  /// Returns the property IDs of all assertions in the trace
+  /// Returns the property IDs of all failed assertions in the trace
   std::vector<irep_idt> get_all_property_ids() const;
 };