Merge pull request #3781 from tautschnig/deprecation-dereference_exprt

Construct dereference_exprt in a non-deprecated way

Author: tautschnig

src/goto-programs/builtin_functions.cpp

@@ -1108,8 +1108,7 @@ void goto_convertt::do_function_call_symbol(
     if(lhs.is_not_nil())
     {
       typet t=pointer_type(lhs.type());
-      dereference_exprt rhs(lhs.type());
-      rhs.op0()=typecast_exprt(list_arg, t);
+      dereference_exprt rhs(typecast_exprt(list_arg, t), lhs.type());
       rhs.add_source_location()=function.source_location();
       goto_programt::targett t2=dest.add_instruction(ASSIGN);
       t2->source_location=function.source_location();

src/goto-symex/symex_dereference.cpp

@@ -312,9 +312,8 @@ void goto_symext::dereference_rec(
     address_of_exprt address_of_expr(index_expr.array());
     address_of_expr.type()=pointer_type(expr.type());
 
-    dereference_exprt tmp;
-    tmp.pointer()=plus_exprt(address_of_expr, index_expr.index());
-    tmp.type()=expr.type();
+    dereference_exprt tmp(
+      plus_exprt(address_of_expr, index_expr.index()), expr.type());
     tmp.add_source_location()=expr.source_location();
 
     // recursive call

src/pointer-analysis/rewrite_index.cpp

@@ -16,9 +16,8 @@ Author: Daniel Kroening, [email protected]
 /// rewrite a[i] to *(a+i)
 dereference_exprt rewrite_index(const index_exprt &index_expr)
 {
-  dereference_exprt result;
-  result.pointer()=plus_exprt(index_expr.array(), index_expr.index());
-  result.type()=index_expr.type();
+  dereference_exprt result(
+    plus_exprt(index_expr.array(), index_expr.index()), index_expr.type());
   result.add_source_location()=index_expr.source_location();
   return result;
 }