code_deadt::check: to_symbol_expr requires a symbol_exprt

tautschnig · tautschnig · commit 3c85341828fe · 2019-03-06T23:22:31.000Z
The error message would fail to print as it uses a conversion that is
invalid for the very reason that the error message wants to print.
diff --git a/src/util/std_code.h b/src/util/std_code.h
@@ -493,8 +493,7 @@ class code_deadt:public codet
     DATA_CHECK(
       vm,
       code.op0().id() == ID_symbol,
-      "removing a non-symbol: " +
-        id2string(to_symbol_expr(code.op0()).get_identifier()) + "from scope");
+      "removing a non-symbol: " + id2string(code.op0().id()) + "from scope");
   }
 
 protected:

Original file line number	Diff line number	Diff line change
`@@ -493,8 +493,7 @@ class code_deadt:public codet`
`493`	`493`	`DATA_CHECK(`
`494`	`494`	`vm,`
`495`	`495`	`code.op0().id() == ID_symbol,`
`496`		`- "removing a non-symbol: " +`
`497`		`- id2string(to_symbol_expr(code.op0()).get_identifier()) + "from scope");`
	`496`	`+ "removing a non-symbol: " + id2string(code.op0().id()) + "from scope");`
`498`	`497`	`}`
`499`	`498`
`500`	`499`	`protected:`