Change separator to comma (fix regression tests)

Author: Petr Bauch

regression/goto-instrument/fp-reachability-slice2/test.desc

@@ -1,6 +1,6 @@
 CORE
 main.c
---fp-reachability-slice a:c
+--fp-reachability-slice a,c
 ^EXIT=0$
 ^SIGNAL=0$
 dead d;

regression/goto-instrument/fp-reachability-slice3/test.desc

@@ -1,6 +1,6 @@
 CORE
 main.c
---fp-reachability-slice b:c
+--fp-reachability-slice b,c
 ^EXIT=0$
 ^SIGNAL=0$
 --

src/goto-instrument/goto_instrument_parse_options.cpp

@@ -1621,7 +1621,7 @@ void goto_instrument_parse_optionst::help()
     "Slicing:\n"
     " --fp-reachability-slice <f>  remove instructions that cannot appear on a\n" // NOLINT(*)
     "                              trace that visits all given functions. The list of functions has to be\n" // NOLINT(*)
-    "                              given as a colon separated list.\n"
+    "                              given as a comma separated list.\n"
     " --reachability-slice         slice away instructions that can't reach assertions\n" // NOLINT(*)
     " --full-slice                 slice away instructions that don't affect assertions\n" // NOLINT(*)
     " --property id                slice with respect to specific property only\n" // NOLINT(*)

src/util/cmdline.cpp

@@ -226,12 +226,12 @@ bool cmdlinet::parse(int argc, const char **argv, const char *optstring)
           options[*optnr].values.push_back(argv[i]+2);
 
         auto &my_values = options[*optnr].values;
-        if(my_values.back().find(':') != std::string::npos)
+        if(my_values.back().find(',') != std::string::npos)
         {
           std::istringstream multiple_values(my_values.back());
           my_values.pop_back();
           std::string single_value;
-          while(std::getline(multiple_values, single_value, ':'))
+          while(std::getline(multiple_values, single_value, ','))
           {
             my_values.push_back(single_value);
           }