Allow remove-internal_symbols to log and return

This commit allows remove_internal_symbols() to take a messaget object
for logging, and to return a boolean to indicate success. This is in
preparation for a commit where this function will emit debugging
information.

Author: karkhaz

src/ansi-c/ansi_c_language.cpp

@@ -118,7 +118,8 @@ bool ansi_c_languaget::typecheck(
     return true;
   }
 
-  remove_internal_symbols(new_symbol_table);
+  if(remove_internal_symbols(new_symbol_table, *this))
+    return true;
 
   if(linking(symbol_table, new_symbol_table, get_message_handler()))
     return true;

src/linking/remove_internal_symbols.cpp

@@ -71,8 +71,7 @@ static void get_symbols(
 ///          http://gcc.gnu.org/ml/gcc/2006-11/msg00006.html
 ///          on "extern inline"
 /// \param symbol_table: symbol table to clean up
-void remove_internal_symbols(
-  symbol_tablet &symbol_table)
+bool remove_internal_symbols(symbol_tablet &symbol_table, messaget &log)
 {
   namespacet ns(symbol_table);
   find_symbols_sett exported;
@@ -165,4 +164,5 @@ void remove_internal_symbols(
       it++;
     }
   }
+  return false;
 }

src/linking/remove_internal_symbols.h

@@ -12,7 +12,8 @@ Author: Daniel Kroening
 #ifndef CPROVER_LINKING_REMOVE_INTERNAL_SYMBOLS_H
 #define CPROVER_LINKING_REMOVE_INTERNAL_SYMBOLS_H
 
-void remove_internal_symbols(
-  class symbol_tablet &symbol_table);
+#include <util/message.h>
+
+bool remove_internal_symbols(class symbol_tablet &symbol_table, messaget &log);
 
 #endif // CPROVER_LINKING_REMOVE_INTERNAL_SYMBOLS_H