Special treatment for static and dynamic array members

If pointer points inside static array we build index_expr. If pointer points
inside dynamic array we build dereference_expr.

Author: petr-bauch

src/memory-analyzer/analyze_symbol.cpp

@@ -299,6 +299,7 @@ exprt gdb_value_extractort::get_pointer_to_member_value(
   }
 
   if(!found)
+  if(struct_symbol->symbol_expr().type().id() == ID_array)
   {
     const typet target_type = expr.type().subtype();
 
@@ -323,15 +324,21 @@ exprt gdb_value_extractort::get_pointer_to_member_value(
 
     const auto maybe_member_expr = get_subexpression_at_offset(
       struct_symbol->second, member_offset, expr.type().subtype(), ns);
-    CHECK_RETURN(maybe_member_expr.has_value());
-    return *maybe_member_expr;
+    if(maybe_member_expr.has_value())
+      return *maybe_member_expr;
+    UNREACHABLE;
+    return index_exprt{
+      struct_symbol->symbol_expr(),
+      from_integer(
+        member_offset / get_type_size(expr.type().subtype()), index_type())};
   }
 
   const auto it = values.find(memory_location);
   // if the structure we are pointing to does not exists we need to build a
   // temporary object for it: get the type from symbol table, query gdb for
   // value, allocate new object for it and then store into assignments
   if(it == values.end())
+  if(struct_symbol->symbol_expr().type().id() == ID_pointer)
   {
     const auto symbol_expr = struct_symbol->symbol_expr();
     const auto zero = zero_initializer(symbol_expr.type(), location, ns);
@@ -347,6 +354,10 @@ exprt gdb_value_extractort::get_pointer_to_member_value(
 
     add_assignment(new_symbol, val);
     values[memory_location] = val;
+    return dereference_exprt{
+      plus_exprt{struct_symbol->symbol_expr(),
+                 from_integer(member_offset, size_type()),
+                 expr.type()}};
   }
 
   const auto maybe_member_expr = get_subexpression_at_offset(