Make sure that member functions are correctly marked as override

martin · martin · commit 246df8afce98 · 2021-07-16T17:33:44.000+01:00
It seems that adding one override to a class triggers clang's override
check.
diff --git a/src/goto-diff/goto_diff_parse_options.h b/src/goto-diff/goto_diff_parse_options.h
@@ -43,8 +43,8 @@ class optionst;
 class goto_diff_parse_optionst : public parse_options_baset
 {
 public:
-  virtual int doit();
-  virtual void help();
+  int doit() override;
+  void help() override;
 
   goto_diff_parse_optionst(int argc, const char **argv);
 
diff --git a/src/goto-instrument/goto_instrument_parse_options.h b/src/goto-instrument/goto_instrument_parse_options.h
@@ -129,8 +129,8 @@ Author: Daniel Kroening, kroening@kroening.com
 class goto_instrument_parse_optionst : public parse_options_baset
 {
 public:
-  virtual int doit();
-  virtual void help();
+  int doit() override;
+  void help() override;
 
   goto_instrument_parse_optionst(int argc, const char **argv)
     : parse_options_baset(

Original file line number	Diff line number	Diff line change
`@@ -43,8 +43,8 @@ class optionst;`
`43`	`43`	`class goto_diff_parse_optionst : public parse_options_baset`
`44`	`44`	`{`
`45`	`45`	`public:`
`46`		`- virtual int doit();`
`47`		`- virtual void help();`
	`46`	`+ int doit() override;`
	`47`	`+ void help() override;`
`48`	`48`
`49`	`49`	`goto_diff_parse_optionst(int argc, const char **argv);`
`50`	`50`