Add a constant for the default max-nondet-string-length

Author: svorenova

src/solvers/strings/max_nondet_string_length_default.h

@@ -0,0 +1,15 @@
+/*******************************************************************\
+
+Module: Defines the default value for max-nondet-string-length command-line
+ option. The value was chosen based on benchmarking.
+
+Author: Maria Svorenova, [email protected]
+
+\*******************************************************************/
+
+#ifndef CPROVER_SOLVERS_STRINGS_MAX_NONDET_STRING_LENGTH_DEFAULT_H
+#define CPROVER_SOLVERS_STRINGS_MAX_NONDET_STRING_LENGTH_DEFAULT_H
+
+const int MAX_NONDET_STRING_LENGTH_DEFAULT = 10000;
+
+#endif // CPROVER_SOLVERS_STRINGS_MAX_NONDET_STRING_LENGTH_DEFAULT_H

src/solvers/strings/string_refinement.h

@@ -25,6 +25,7 @@ Author: Alberto Griggio, [email protected]
 #include <util/string_expr.h>
 #include <util/union_find_replace.h>
 
+#include "max_nondet_string_length_default.h"
 #include "string_constraint.h"
 #include "string_constraint_generator.h"
 #include "string_refinement_invariant.h"
@@ -46,7 +47,7 @@ Author: Alberto Griggio, [email protected]
   "                              the switch can be used multiple times to give\n" /* NOLINT(*) */ \
   "                              several strings\n" /* NOLINT(*) */ \
   " --max-nondet-string-length n bound the length of nondet (e.g. input) strings;\n" /* NOLINT(*) */ \
-  "                              set to 10000 by default\n" /* NOLINT(*) */
+  "                              set to " + std::to_string(MAX_NONDET_STRING_LENGTH_DEFAULT) + " by default\n" /* NOLINT(*) */
 
 // The integration of the string solver into CBMC is incomplete. Therefore,
 // it is not turned on by default and not all options are available.

src/util/object_factory_parameters.cpp

@@ -8,6 +8,7 @@ Author: Diffblue Ltd
 
 #include "object_factory_parameters.h"
 
+#include <solvers/strings/max_nondet_string_length_default.h>
 #include <util/cmdline.h>
 #include <util/options.h>
 
@@ -76,7 +77,8 @@ void parse_object_factory_options(const cmdlinet &cmdline, optionst &options)
   }
   else if(!cmdline.isset("no-refine-strings"))
   {
-    options.set_option("max-nondet-string-length", 10000);
+    options.set_option(
+      "max-nondet-string-length", MAX_NONDET_STRING_LENGTH_DEFAULT);
   }
   if(cmdline.isset("string-printable"))
   {