Merge pull request #3226 from owen-jones-diffblue/cleanup/throw-exception-instead-of-string

Don't throw bare string "Failed to find state"

Author: tautschnig

src/analyses/ai.h

@@ -305,7 +305,7 @@ class ait:public ai_baset
   {
     typename state_mapt::iterator it=state_map.find(l);
     if(it==state_map.end())
-      throw "failed to find state";
+      throw std::out_of_range("failed to find state");
 
     return it->second;
   }
@@ -314,7 +314,7 @@ class ait:public ai_baset
   {
     typename state_mapt::const_iterator it=state_map.find(l);
     if(it==state_map.end())
-      throw "failed to find state";
+      throw std::out_of_range("failed to find state");
 
     return it->second;
   }
@@ -355,7 +355,7 @@ class ait:public ai_baset
   {
     typename state_mapt::const_iterator it=state_map.find(l);
     if(it==state_map.end())
-      throw "failed to find state";
+      throw std::out_of_range("failed to find state");
 
     return it->second;
   }

src/analyses/static_analysis.h

@@ -291,7 +291,7 @@ class static_analysist:public static_analysis_baset
   {
     typename state_mapt::iterator it=state_map.find(l);
     if(it==state_map.end())
-      throw "failed to find state";
+      throw std::out_of_range("failed to find state");
 
     return it->second;
   }
@@ -300,7 +300,7 @@ class static_analysist:public static_analysis_baset
   {
     typename state_mapt::const_iterator it=state_map.find(l);
     if(it==state_map.end())
-      throw "failed to find state";
+      throw std::out_of_range("failed to find state");
 
     return it->second;
   }
@@ -324,7 +324,7 @@ class static_analysist:public static_analysis_baset
   {
     typename state_mapt::iterator it=state_map.find(l);
     if(it==state_map.end())
-      throw "failed to find state";
+      throw std::out_of_range("failed to find state");
 
     return it->second;
   }
@@ -333,7 +333,7 @@ class static_analysist:public static_analysis_baset
   {
     typename state_mapt::const_iterator it=state_map.find(l);
     if(it==state_map.end())
-      throw "failed to find state";
+      throw std::out_of_range("failed to find state");
 
     return it->second;
   }