Add header for magic numbers

All magic numbers throughout the codebase should eventually be added to
this file.

Author: karkhaz

src/solvers/flattening/boolbv.cpp

@@ -15,6 +15,7 @@ Author: Daniel Kroening, [email protected]
 #include <util/symbol.h>
 #include <util/mp_arith.h>
 #include <util/arith_tools.h>
+#include <util/magic.h>
 #include <util/replace_expr.h>
 #include <util/std_types.h>
 #include <util/prefix.h>
@@ -688,7 +689,7 @@ bool boolbvt::is_unbounded_array(const typet &type) const
     return true;
 
   if(unbounded_array==unbounded_arrayt::U_AUTO)
-    if(s>1000) // magic number!
+    if(s>MAX_FLATTENED_ARRAY_SIZE)
       return true;
 
   return false;

src/util/magic.h

@@ -0,0 +1,12 @@
+/// \file
+/// \brief Magic numbers used throughout the codebase
+/// \author Kareem Khazem <[email protected]>
+
+#ifndef CPROVER_UTIL_MAGIC_H
+#define CPROVER_UTIL_MAGIC_H
+
+#include <cstddef>
+
+const std::size_t MAX_FLATTENED_ARRAY_SIZE=1000;
+
+#endif