Comment on potential gotcha

NathanJPhillips · NathanJPhillips · commit 1855bcddf766 · 2017-03-14T10:20:58.000Z
Added comment on hard to track potential error caused by #define in irep_hash
This could save external users time (internal users shouldn't encounter this as we don't use Boost)
diff --git a/src/util/irep_hash.h b/src/util/irep_hash.h
@@ -148,6 +148,8 @@ inline std::size_t basic_hash_finalize(
   return h1;
 }
 
+// Boost uses the symbol hash_combine, if you're getting problems here then
+//  you've probably included a Boost header after this one
 #define hash_combine(h1, h2) \
   basic_hash_combine<sizeof(std::size_t)*8>(h1, h2)
 #define hash_finalize(h1, len) \

Original file line number	Diff line number	Diff line change
`@@ -148,6 +148,8 @@ inline std::size_t basic_hash_finalize(`
`148`	`148`	`return h1;`
`149`	`149`	`}`
`150`	`150`
	`151`	`+// Boost uses the symbol hash_combine, if you're getting problems here then`
	`152`	`+// you've probably included a Boost header after this one`
`151`	`153`	`#define hash_combine(h1, h2) \`
`152`	`154`	`basic_hash_combine<sizeof(std::size_t)*8>(h1, h2)`
`153`	`155`	`#define hash_finalize(h1, len) \`