use make_assignment(lhs, rhs)

This is slightly shorter.

Author: Daniel Kroening

src/analyses/goto_check.cpp

@@ -1833,7 +1833,7 @@ void goto_checkt::goto_check(
             lhs);
           goto_programt::targett t =
             new_code.add(goto_programt::make_assignment(
-              code_assignt(std::move(lhs), std::move(rhs)), i.source_location));
+              std::move(lhs), std::move(rhs), i.source_location));
           t->code.add_source_location()=i.source_location;
         }
       }
@@ -1848,8 +1848,7 @@ void goto_checkt::goto_check(
         const symbol_exprt leak_expr=leak.symbol_expr();
 
         // add self-assignment to get helpful counterexample output
-        new_code.add(
-          goto_programt::make_assignment(code_assignt(leak_expr, leak_expr)));
+        new_code.add(goto_programt::make_assignment(leak_expr, leak_expr));
 
         source_locationt source_location;
         source_location.set_function(function_identifier);

src/goto-instrument/dump_c.cpp

@@ -593,7 +593,7 @@ void dump_ct::cleanup_decl(
   tmp.add(goto_programt::make_decl(decl.symbol()));
 
   if(value.is_not_nil())
-    tmp.add(goto_programt::make_assignment(code_assignt(decl.op0(), value)));
+    tmp.add(goto_programt::make_assignment(decl.symbol(), value));
 
   tmp.add(goto_programt::make_end_function());