Add a constant for the default max-nondet-string-length

Author: svorenova

src/solvers/strings/string_refinement.h

@@ -21,6 +21,7 @@ Author: Alberto Griggio, [email protected]
 #define CPROVER_SOLVERS_REFINEMENT_STRING_REFINEMENT_H
 
 #include <limits>
+#include <util/magic.h>
 #include <util/replace_expr.h>
 #include <util/string_expr.h>
 #include <util/union_find_replace.h>
@@ -46,7 +47,7 @@ Author: Alberto Griggio, [email protected]
   "                              the switch can be used multiple times to give\n" /* NOLINT(*) */ \
   "                              several strings\n" /* NOLINT(*) */ \
   " --max-nondet-string-length n bound the length of nondet (e.g. input) strings;\n" /* NOLINT(*) */ \
-  "                              set to 10000 by default\n" /* NOLINT(*) */
+  "                              set to " + std::to_string(MAX_NONDET_STRING_LENGTH_DEFAULT) + " by default\n" /* NOLINT(*) */
 
 // The integration of the string solver into CBMC is incomplete. Therefore,
 // it is not turned on by default and not all options are available.

src/util/magic.h

@@ -16,4 +16,6 @@ const std::size_t MAX_CONCRETE_STRING_SIZE = 1 << 26;
 // The top end of the range of integers for which dstrings are precomputed
 constexpr std::size_t DSTRING_NUMBERS_MAX = 64;
 
+const int MAX_NONDET_STRING_LENGTH_DEFAULT = 10000;
+
 #endif

src/util/object_factory_parameters.cpp

@@ -8,8 +8,9 @@ Author: Diffblue Ltd
 
 #include "object_factory_parameters.h"
 
-#include <util/cmdline.h>
-#include <util/options.h>
+#include "cmdline.h"
+#include "magic.h"
+#include "options.h"
 
 void object_factory_parameterst::set(const optionst &options)
 {
@@ -68,6 +69,7 @@ void parse_object_factory_options(const cmdlinet &cmdline, optionst &options)
     options.set_option(
       "min-null-tree-depth", cmdline.get_value("min-null-tree-depth"));
   }
+
   if(cmdline.isset("max-nondet-string-length"))
   {
     options.set_option(
@@ -76,8 +78,10 @@ void parse_object_factory_options(const cmdlinet &cmdline, optionst &options)
   }
   else if(!cmdline.isset("no-refine-strings"))
   {
-    options.set_option("max-nondet-string-length", 10000);
+    options.set_option(
+      "max-nondet-string-length", MAX_NONDET_STRING_LENGTH_DEFAULT);
   }
+
   if(cmdline.isset("string-printable"))
   {
     options.set_option("string-printable", true);