Address comments wrt regression tests

Mostly specifying why they are not supported now.

Author: petr-bauch

regression/memory-analyzer/arrays/test.desc

@@ -1,8 +1,8 @@
 FUTURE
-arrays.exe
+arrays.gb
 --breakpoint manipulate_data --symbols test_struct
 analyzing symbol: test_struct
-GENERATED CODE: 
+GENERATED CODE:
 \{
   char _test_struct_childs0_options0_text_1\[\]="accept";
   char _test_struct_childs0_options1_text_2\[\]="unique0";
@@ -11,14 +11,17 @@ GENERATED CODE:
   char _test_struct_childs3_options1_text_5\[\]="unique3";
   struct a_typet test_struct_0=\{ .config=\{ 10, 11, 12, 13, 14, 15, 16, 17, 18, 19 \}, .initalized=0,
     .values=\{ 243, 243, 243, 243, 243, 243, 243, 243, 243, 243, 63, 63, 63, 63, 63, 63, 63, 63, 63, 63, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 171, 171, 171, 171, 171, 171, 171, 171, 171, 171 \}, .childs=\{ \{ .id=12, .options=\{ \{ .text=\(char \*\)&_test_struct_childs0_options0_text_1 \},
-    \{ .text=\(char \*\)&_test_struct_childs0_options1_text_2 \} \} \}, 
+    \{ .text=\(char \*\)&_test_struct_childs0_options1_text_2 \} \} \},
     \{ .id=13, .options=\{ \{ .text=\(char \*\)&_test_struct_childs0_options0_text_1 \},
-    \{ .text=\(char \*\)&_test_struct_childs1_options1_text_3 \} \} \}, 
+    \{ .text=\(char \*\)&_test_struct_childs1_options1_text_3 \} \} \},
     \{ .id=14, .options=\{ \{ .text=\(char \*\)&_test_struct_childs0_options0_text_1 \},
-    \{ .text=\(char \*\)&_test_struct_childs2_options1_text_4 \} \} \}, 
+    \{ .text=\(char \*\)&_test_struct_childs2_options1_text_4 \} \} \},
     \{ .id=15, .options=\{ \{ .text=\(char \*\)&_test_struct_childs0_options0_text_1 \},
     \{ .text=\(char \*\)&_test_struct_childs3_options1_text_5 \} \} \} \} \};
   test_struct = &test_struct_0;
 \}
 ^EXIT=0$
 ^SIGNAL=0$
+--
+--
+`values` is an array of unsigned chars which we currently cannot extract from GDB

regression/memory-analyzer/arrays_01/test.desc

@@ -1,5 +1,5 @@
 CORE
-main.exe
+main.gb
 --breakpoint checkpoint --symbols array
 array = \{ 1, 4, 3 \};
 ^EXIT=0$

regression/memory-analyzer/chain.sh

@@ -5,8 +5,8 @@ set -e
 memory_analyzer=$1
 goto_gcc=$2
 name=${*:$#}
-name=${name%.exe}
+name=${name%.gb}
 args=${*:3:$#-3}
 
-$goto_gcc -g -std=c11 -o "${name}.exe" "${name}.c"
-$memory_analyzer $args "${name}.exe"
+$goto_gcc -g -std=c11 -o "${name}.gb" "${name}.c"
+$memory_analyzer $args "${name}.gb"

regression/memory-analyzer/cycles/test.desc

@@ -1,16 +1,23 @@
-FUTURE
-cycles.exe
+CORE
+cycles.gb
 --breakpoint process_buffer --symbols buffer
-char buffer_start__data_1\[\]="snow";
-char buffer_start__next__data_3\[\]="sun";
-char buffer_start__next__next__data_5\[\]="rain";
-char buffer_start__next__next__next__data_7\[\]="thunder storm";
-struct cycle_buffer_entry buffer_start__next__next__next_6\=\{ \.data\=\(char \*\)&buffer_start__next__next__next__data_7, \.next\=\(\(struct cycle_buffer_entry \*\)NULL\) \};
-struct cycle_buffer_entry buffer_start__next__next_4\=\{ \.data\=\(char \*\)&buffer_start__next__next__data_5, \.next\=&buffer_start__next__next__next_6 \};
-struct cycle_buffer_entry buffer_start__next_2\=\{ \.data\=\(char \*\)&buffer_start__next__data_3, \.next\=&buffer_start__next__next_4 \};
-cycle_buffer_entry_t buffer_start_0\=\{ \.data\=\(char \*\)&buffer_start__data_1, \.next\=&buffer_start__next_2 \};
-buffer\.start \= &buffer_start_0;
-buffer\.end \= &buffer_start__next__next__next_6;
-buffer\.start\-\>next\-\>next\-\>next\-\>next \= &buffer_start_0;
+cycle_buffer_entry_t tmp;
+char tmp\$0\[\];
+struct cycle_buffer_entry tmp\$1;
+char tmp\$2\[\];
+struct cycle_buffer_entry tmp\$3;
+char tmp\$4\[\];
+struct cycle_buffer_entry tmp\$5;
+char tmp\$6\[\];
+tmp\$0 = \"snow\";
+tmp\$2 = \"sun\";
+tmp\$4 = \"rain\";
+tmp\$6 = \"thunder storm\";
+tmp\$5 = \{ .data=tmp\$6, .next=\(\(struct cycle_buffer_entry \*\)0\) \};
+tmp\$3 = \{ .data=tmp\$4, .next=&tmp\$5 \};
+tmp\$1 = \{ .data=tmp\$2, .next=&tmp\$3 \};
+tmp = \{ .data=tmp\$0, .next=&tmp\$1 \};
+buffer = \{ .start=&tmp, .end=&tmp\$5 \};
+buffer.start->next->next->next->next = &tmp;
 ^EXIT=0$
 ^SIGNAL=0$

regression/memory-analyzer/json-output_01/test.desc

@@ -1,5 +1,5 @@
 CORE
-main.exe
+main.gb
 --breakpoint checkpoint --symbols x,p,st,a --symtab-snapshot --json-ui
 ^EXIT=0$
 ^SIGNAL=0$

regression/memory-analyzer/primitive_types/primitive_types.c renamed to regression/memory-analyzer/plain_old_datatypes/plain_old_datatypes.c

@@ -5,7 +5,7 @@
 /// Pointer references are tested and ensured, that for example f and f_1 are
 /// pointing to the same int value location after running memory-analyzer.
 
-#include "primitive_types.h"
+#include "plain_old_datatypes.h"
 int my_function(char *s)
 {
   int a = 10;

regression/memory-analyzer/primitive_types/primitive_types.h renamed to regression/memory-analyzer/plain_old_datatypes/plain_old_datatypes.h

@@ -0,0 +1,17 @@
+CORE
+plain_old_datatypes.gb
+--breakpoint my_function --symbols e,f,f_1,d,g,h
+^EXIT=0$
+^SIGNAL=0$
+char tmp\[\];
+struct mapping_things tmp\$0;
+char tmp\$1\[\];
+e = 17;
+f = &e;
+f_1 = &e;
+tmp = \"test2\";
+d = \{ .a=4, .b=tmp, .c=-32 \};
+tmp\$0 = \{ .a=0, .b=\(\(char \*\)0\), .c=0 \};
+g = &tmp\$0;
+tmp\$1 = \"test\";
+h = tmp\$1;

regression/memory-analyzer/plain_old_datatypes/test.desc

@@ -1,5 +1,5 @@
 CORE
-main.exe
+main.gb
 --breakpoint checkpoint --symbols x,p
 x = 3;
 p = &x;

regression/memory-analyzer/pointer_01/test.desc

@@ -1,5 +1,5 @@
 CORE
-main.exe
+main.gb
 --breakpoint checkpoint --symbols p,x
 ^EXIT=0$
 ^SIGNAL=0$

regression/memory-analyzer/pointer_02/test.desc

@@ -1,5 +1,5 @@
 CORE
-main.exe
+main.gb
 --breakpoint checkpoint --symbols x,p
 x = 3;
 p = &x;

regression/memory-analyzer/pointer_03/test.desc

@@ -1,5 +1,5 @@
 CORE
-main.exe
+main.gb
 --breakpoint checkpoint --symbols x,p1,p2
 ^EXIT=0$
 ^SIGNAL=0$

regression/memory-analyzer/pointer_04/test.desc

@@ -1,5 +1,5 @@
 CORE
-main.exe
+main.gb
 --breakpoint checkpoint --symbols p1,x,p2
 ^EXIT=0$
 ^SIGNAL=0$

regression/memory-analyzer/pointer_05/test.desc

@@ -1,5 +1,5 @@
 CORE
-main.exe
+main.gb
 --breakpoint checkpoint --symbols p,x
 ^EXIT=0$
 ^SIGNAL=0$

regression/memory-analyzer/pointer_06/test.desc

@@ -1,5 +1,5 @@
 CORE
-main.exe
+main.gb
 --breakpoint checkpoint --symbols p
 ^EXIT=0$
 ^SIGNAL=0$

regression/memory-analyzer/pointer_07/test.desc

@@ -1,5 +1,8 @@
 KNOWNBUG
-main.exe
+main.gb
 --breakpoint checkpoint --symbols p
 ^EXIT=0$
 ^SIGNAL=0$
+--
+--
+p has type void*, the value it points to has type void; right now we can't initialize expression of that type

regression/memory-analyzer/pointer_08/test.desc

@@ -1,5 +1,5 @@
 CORE
-main.exe
+main.gb
 --breakpoint checkpoint --symbols p
 struct S tmp;
 tmp = \{ \.next=\(\(struct S \*\)(NULL|0)\) \};

regression/memory-analyzer/pointer_to_struct_01/test.desc

@@ -1,8 +1,8 @@
-KNOWNBUG
-main.exe
+CORE
+main.gb
 --breakpoint checkpoint --symbols s
-char tmp\[4\];
-tmp = "abc";
+char tmp\[\];
+tmp = \"abc\";
 s = tmp;
 ^EXIT=0$
 ^SIGNAL=0$

regression/memory-analyzer/primitive_types/test.desc

@@ -1,5 +1,5 @@
 CORE
-main.exe
+main.gb
 --breakpoint checkpoint --symbols st
 st = \{ .c1=1, .c2=3 \};
 ^EXIT=0$

regression/memory-analyzer/strings_01/test.desc

@@ -1,5 +1,5 @@
 CORE
-main.exe
+main.gb
 --breakpoint checkpoint --symbols st
 signed int tmp;
 tmp = 3;

regression/memory-analyzer/structs_01/test.desc

@@ -1,8 +1,8 @@
-KNOWNBUG
-main.exe
+CORE
+main.gb
 --breakpoint checkpoint --symbols st
-char tmp[4];
-tmp = "abc";
+char tmp\[\];
+tmp = \"abc\";
 st = \{ .c1=1, .c2=tmp \};
 ^EXIT=0$
 ^SIGNAL=0$

regression/memory-analyzer/structs_02/test.desc

@@ -1,6 +1,9 @@
 KNOWNBUG
-main.exe
+main.gb
 --breakpoint checkpoint --symbols st
 st = \{ .c1=1, .c2='x' \};
 ^EXIT=0$
 ^SIGNAL=0$
+--
+--
+cannot extract single characters from GDB for now

regression/memory-analyzer/structs_03/test.desc

@@ -1,5 +1,5 @@
 CORE
-main.exe
+main.gb
 --breakpoint checkpoint --symbols st
 st = \{ .c1=1, .a=\{ 2, 3 \} \};
 ^EXIT=0$

regression/memory-analyzer/structs_04/test.desc

@@ -1,5 +1,5 @@
 CORE
-main.exe
+main.gb
 --breakpoint checkpoint --symbols st
 st = \{ \.c=1, \.t=\{ \.i=2 \} \};
 ^EXIT=0$

regression/memory-analyzer/structs_05/test.desc

@@ -1,5 +1,8 @@
 KNOWNBUG
-void_pointer.exe
+void_pointer.gb
 --breakpoint void_pointer.c:17 --symbols a_void_pointer,a_second_void_pointer,a_third_void_pointer,blob
 ^EXIT=0$
 ^SIGNAL=0$
+--
+--
+void pointer unsupported for now