Modify boolbvt and bv_pointerst to incorporate get_array_constraints boolean option used in arrayst class

Add an additional boolean argument to the class constrcutor to propagate the setting of
parse option --show-array-constraints to true to the arrayst class. The entry point for this
is in the default invocation of solver factory.

clang format solver_factory and bv_pointers

Author: Natasha Yogananda Jeppu

src/goto-checker/solver_factory.cpp

@@ -219,9 +219,10 @@ std::unique_ptr<solver_factoryt::solvert> solver_factoryt::get_default()
     solver->set_prop(make_satcheck_prop<satcheckt>(message_handler, options));
   }
 
-  bool get_array_constraints = options.get_bool_option("show-array-constraints");
-  auto bv_pointers =
-    util_make_unique<bv_pointerst>(ns, solver->prop(), message_handler, get_array_constraints);
+  bool get_array_constraints =
+    options.get_bool_option("show-array-constraints");
+  auto bv_pointers = util_make_unique<bv_pointerst>(
+    ns, solver->prop(), message_handler, get_array_constraints);
 
   if(options.get_option("arrays-uf") == "never")
     bv_pointers->unbounded_array = bv_pointerst::unbounded_arrayt::U_NONE;

src/solvers/flattening/bv_pointers.cpp

@@ -84,7 +84,8 @@ bv_pointerst::bv_pointerst(
   propt &_prop,
   message_handlert &message_handler,
   bool get_array_constraints)
-  : boolbvt(_ns, _prop, message_handler, get_array_constraints), pointer_logic(_ns)
+  : boolbvt(_ns, _prop, message_handler, get_array_constraints),
+    pointer_logic(_ns)
 {
   object_bits=config.bv_encoding.object_bits;
   std::size_t pointer_width = boolbv_width(pointer_type(empty_typet()));