Disable a number of invariants that currently fail

This takes us back to the behaviour prior to this series of commits, and
effectively is a to-do list to be addressed. We should either handle the cases,
or get rid of the instruction type.

Author: tautschnig

src/analyses/escape_analysis.cpp

@@ -272,7 +272,9 @@ void escape_domaint::transform(
   case SKIP:         // No action required
     break;
   case OTHER:
+#if 0
     DATA_INVARIANT(false, "Unclear what is a safe over-approximation of OTHER");
+#endif
     break;
   case INCOMPLETE_GOTO:
   case NO_INSTRUCTION_TYPE:

src/analyses/interval_domain.cpp

@@ -125,7 +125,9 @@ void interval_domaint::transform(
   case SKIP:         // No action required
     break;
   case OTHER:
+#if 0
     DATA_INVARIANT(false, "Unclear what is a safe over-approximation of OTHER");
+#endif
     break;
   case INCOMPLETE_GOTO:
   case NO_INSTRUCTION_TYPE:

src/analyses/local_bitvector_analysis.cpp

@@ -313,8 +313,10 @@ void local_bitvector_analysist::build()
       DATA_INVARIANT(false, "Exceptions must be removed before analysis");
       break;
     case RETURN:
+#if 0
       DATA_INVARIANT(false, "Returns must be removed before analysis");
       break;
+#endif
     case ATOMIC_BEGIN: // Ignoring is a valid over-approximation
     case ATOMIC_END:   // Ignoring is a valid over-approximation
     case LOCATION:     // No action required
@@ -327,8 +329,10 @@ void local_bitvector_analysist::build()
     case END_FUNCTION: // No action required
       break;
     case OTHER:
+#if 0
       DATA_INVARIANT(
         false, "Unclear what is a safe over-approximation of OTHER");
+#endif
       break;
     case INCOMPLETE_GOTO:
     case NO_INSTRUCTION_TYPE:

src/analyses/local_may_alias.cpp

@@ -422,7 +422,9 @@ void local_may_aliast::build(const goto_functiont &goto_function)
       DATA_INVARIANT(false, "Exceptions must be removed before analysis");
       break;
     case RETURN:
+#if 0
       DATA_INVARIANT(false, "Returns must be removed before analysis");
+#endif
       break;
     case GOTO:         // Ignoring the guard is a valid over-approximation
     case START_THREAD: // Require a concurrent analysis at higher level
@@ -436,8 +438,10 @@ void local_may_aliast::build(const goto_functiont &goto_function)
     case ASSUME:       // Ignoring is a valid over-approximation
       break;
     case OTHER:
+#if 0
       DATA_INVARIANT(
         false, "Unclear what is a safe over-approximation of OTHER");
+#endif
       break;
     case INCOMPLETE_GOTO:
     case NO_INSTRUCTION_TYPE:

src/analyses/uncaught_exceptions_analysis.cpp

@@ -130,7 +130,9 @@ void uncaught_exceptions_domaint::transform(
   case ASSIGN: // Safe to ignore in this context
     break;
   case RETURN:
+#if 0
     DATA_INVARIANT(false, "Returns must be removed before analysis");
+#endif
     break;
   case GOTO:         // Ignoring the guard is a valid over-approximation
   case ATOMIC_BEGIN: // Ignoring is a valid over-approximation
@@ -144,7 +146,9 @@ void uncaught_exceptions_domaint::transform(
   case SKIP:         // No action required
     break;
   case OTHER:
+#if 0
     DATA_INVARIANT(false, "Unclear what is a safe over-approximation of OTHER");
+#endif
     break;
   case INCOMPLETE_GOTO:
   case NO_INSTRUCTION_TYPE: