refactor: fix issues according to golangci-lint

Author: IronCore864

cmd/argocd/main.go

@@ -16,22 +16,22 @@ type Plugin string
 // Install implements the installation of ArgoCD.
 func (p Plugin) Install(options *map[string]interface{}) {
 	argocd.Install(options)
-	log.Println("argocd install finished")
+	log.Printf("%s install finished", NAME)
 }
 
 // Reinstall implements the reinstallation of ArgoCD.
 func (p Plugin) Reinstall(options *map[string]interface{}) {
-	log.Println("mock: argocd reinstall finished")
+	log.Printf("mock: %s reinstall finished", NAME)
 }
 
 // Uninstall implements the uninstallation of ArgoCD.
 func (p Plugin) Uninstall(options *map[string]interface{}) {
-	log.Println("mock: argocd uninstall finished")
+	log.Printf("mock: %s uninstall finished", NAME)
 }
 
 // DevStreamPlugin is the exported variable used by the DevStream core.
 var DevStreamPlugin Plugin
 
 func main() {
-	fmt.Println("This is a plugin for DevStream. Use it with DevStream.")
+	fmt.Printf("%T: %s is a plugin for DevStream. Use it with DevStream.\n", NAME, DevStreamPlugin)
 }

cmd/argocdapp/main.go

@@ -16,22 +16,22 @@ type Plugin string
 // Install implements the installation of an ArgoCD app.
 func (p Plugin) Install(options *map[string]interface{}) {
 	argocdapp.Install(options)
-	log.Println("argocdapps install finished")
+	log.Printf("%s install finished", NAME)
 }
 
 // Reinstall implements the installation of an ArgoCD app.
 func (p Plugin) Reinstall(options *map[string]interface{}) {
-	log.Println("mock: argocdapps reinstall finished")
+	log.Printf("mock: %s reinstall finished", NAME)
 }
 
 // Uninstall Uninstall the installation of an ArgoCD app.
 func (p Plugin) Uninstall(options *map[string]interface{}) {
-	log.Println("mock: argocdapps uninstall finished")
+	log.Printf("mock: %s uninstall finished", NAME)
 }
 
 // DevStreamPlugin is the exported variable used by the DevStream core.
 var DevStreamPlugin Plugin
 
 func main() {
-	fmt.Println("This is a plugin for DevStream. Use it with DevStream.")
+	fmt.Printf("%T: %s is a plugin for DevStream. Use it with DevStream.\n", NAME, DevStreamPlugin)
 }

cmd/devstream/main.go

@@ -1,6 +1,8 @@
 package main
 
 import (
+	"log"
+
 	"github.com/spf13/cobra"
 )
 
@@ -14,11 +16,6 @@ var (
 	}
 )
 
-// Execute runs the rootCMD's Execute func.
-func Execute() error {
-	return rootCMD.Execute()
-}
-
 func init() {
 	rootCMD.PersistentFlags().StringVarP(&configFile, "config-file", "f", "config.yaml", "config file")
 
@@ -27,5 +24,8 @@ func init() {
 }
 
 func main() {
-	rootCMD.Execute()
+	err := rootCMD.Execute()
+	if err != nil {
+		log.Fatal(err)
+	}
 }

cmd/githubactions/main.go

@@ -16,22 +16,22 @@ type Plugin string
 // Install implements the installation of some GitHub Actions workflows.
 func (p Plugin) Install(options *map[string]interface{}) {
 	githubactions.Install(options)
-	log.Println("github actions install finished")
+	log.Printf("%s install finished", NAME)
 }
 
 // Reinstall implements the installation of some GitHub Actions workflows.
 func (p Plugin) Reinstall(options *map[string]interface{}) {
-	log.Println("mock: github actions reinstall finished")
+	log.Printf("mock: %s reinstall finished", NAME)
 }
 
 // Uninstall implements the installation of some GitHub Actions workflows.
 func (p Plugin) Uninstall(options *map[string]interface{}) {
-	log.Println("mock: github actions uninstall finished")
+	log.Printf("mock: %s uninstall finished", NAME)
 }
 
 // DevStreamPlugin is the exported variable used by the DevStream core.
 var DevStreamPlugin Plugin
 
 func main() {
-	fmt.Println("This is a plugin for DevStream. Use it with DevStream.")
+	fmt.Printf("%T: %s is a plugin for DevStream. Use it with DevStream.\n", NAME, DevStreamPlugin)
 }

internal/pkg/githubactions/githubactions.go

@@ -15,12 +15,16 @@ func generateGitHubWorkflowFileByName(f string) string {
 }
 
 func getGitHubToken() string {
-	viper.BindEnv("github_token")
-	token, ok := viper.Get("github_token").(string)
+	err := viper.BindEnv("github_token")
+	if err != nil {
+		log.Fatalf("ENV var GITHUB_TOKEN is needed")
+	}
 
+	token, ok := viper.Get("github_token").(string)
 	if !ok {
 		log.Fatalf("ENV var GITHUB_TOKEN is needed")
 	}
+
 	return token
 }