Skip to content

Commit c416e90

Browse files
committed
feat(@angular/cli): disable progress when running outside TTY
The default value is changed from `true` to `progress.stdout.isTTY`. It still has lower priority than value specified by command line flag or in the .angular-cli.json config. Fixes angular#8148
1 parent 15cf37e commit c416e90

File tree

9 files changed

+15
-12
lines changed

9 files changed

+15
-12
lines changed

docs/documentation/build.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -261,7 +261,7 @@ Note: service worker support is experimental and subject to change.
261261
<details>
262262
<summary>progress</summary>
263263
<p>
264-
<code>--progress</code> (aliases: <code>-pr</code>) <em>default value: true</<em>
264+
<code>--progress</code> (aliases: <code>-pr</code>) <em>default value: true inside TTY, false otherwise</<em>
265265
</p>
266266
<p>
267267
Log progress to the console while building.

docs/documentation/eject.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -165,7 +165,7 @@ ng eject
165165
<details>
166166
<summary>progress</summary>
167167
<p>
168-
<code>--progress</code> (aliases: <code>-pr</code>) <em>default value: true</em>
168+
<code>--progress</code> (aliases: <code>-pr</code>) <em>default value: true inside TTY, false otherwise</em>
169169
</p>
170170
<p>
171171
Log progress to the console while building.

docs/documentation/serve.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -234,7 +234,7 @@ All the build Options are available in serve, below are the additional options.
234234
<details>
235235
<summary>progress</summary>
236236
<p>
237-
<code>--progress</code> (aliases: <code>-pr</code>) <em>default value: true</em>
237+
<code>--progress</code> (aliases: <code>-pr</code>) <em>default value: true inside TTY, false otherwise</em>
238238
</p>
239239
<p>
240240
Log progress to the console while building.

docs/documentation/test.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ You can run tests with coverage via `--code-coverage`. The coverage report will
109109
<details>
110110
<summary>progress</summary>
111111
<p>
112-
<code>--progress</code> <em>default value: true</em>
112+
<code>--progress</code> <em>default value: true inside TTY, false otherwise</em>
113113
</p>
114114
<p>
115115
Log progress to the console while in progress.

docs/documentation/xi18n.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@
5959
<details>
6060
<summary>progress</summary>
6161
<p>
62-
<code>--progress</code>
62+
<code>--progress</code> <em>default value: true inside TTY, false otherwise</<em>
6363
</p>
6464
<p>
6565
Log progress to the console while running.

packages/@angular/cli/commands/build.ts

+3-1
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,9 @@ export const baseBuildCommandOptions: any = [
8383
type: Boolean,
8484
aliases: ['pr'],
8585
description: 'Log progress to the console while building.',
86-
default: buildConfigDefaults['progress']
86+
default: typeof buildConfigDefaults['progress'] !== 'undefined'
87+
? buildConfigDefaults['progress']
88+
: process.stdout.isTTY === true
8789
},
8890
{
8991
name: 'i18n-file',

packages/@angular/cli/commands/test.ts

+4-2
Original file line numberDiff line numberDiff line change
@@ -64,8 +64,10 @@ const TestCommand = Command.extend({
6464
{
6565
name: 'progress',
6666
type: Boolean,
67-
default: testConfigDefaults['progress'],
68-
description: 'Log progress to the console while in progress.'
67+
description: 'Log progress to the console while in progress.',
68+
default: typeof testConfigDefaults['progress'] !== 'undefined'
69+
? testConfigDefaults['progress']
70+
: process.stdout.isTTY === true,
6971
},
7072
{
7173
name: 'browsers',

packages/@angular/cli/commands/xi18n.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -36,8 +36,8 @@ const Xi18nCommand = Command.extend({
3636
{
3737
name: 'progress',
3838
type: Boolean,
39-
default: true,
40-
description: 'Log progress to the console while running.'
39+
description: 'Log progress to the console while running.',
40+
default: process.stdout.isTTY === true,
4141
},
4242
{
4343
name: 'app',

packages/@angular/cli/lib/config/schema.json

+1-2
Original file line numberDiff line numberDiff line change
@@ -471,8 +471,7 @@
471471
},
472472
"progress": {
473473
"description": "The ssl key used by the server.",
474-
"type": "boolean",
475-
"default": true
474+
"type": "boolean"
476475
},
477476
"poll": {
478477
"description": "Enable and define the file watching poll time period (milliseconds).",

0 commit comments

Comments
 (0)