Skip to content

Commit 348bdd7

Browse files
TheLarkInnjohannes.werner
authored and
johannes.werner
committed
fix: fixes for path mappings, tests, and coverage (angular#1359)
* fix(): Multiple fixes for path mappings: * Removed invalid test case that was throwing path mappings tests because of a typescript bug. * Readded PathsPlugin for Path Mappings * Removed coverage preprocessor which was throwing bad type errors against ts code when it shouldn't be. * Added sourcemap support for istanbul instrumenter. Coverage files are still being generated. * fix: fix the way the build command runs for mobile tests * fix: fix the way the build command runs for mobile tests * fix: replaced promise based ng command with sh.exec to allow mappings test to run correctly against mobile * fix: replaced promise based ng command with sh.exec to allow mappings test to run correctly against mobile
1 parent 688eadb commit 348bdd7

File tree

2 files changed

+1
-5
lines changed

2 files changed

+1
-5
lines changed

addon/ng2/models/webpack-build-test.ts

+1-2
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,6 @@ export const getWebpackTestConfig = function(projectRoot: string) {
4444
query: {
4545
useWebpackText: true,
4646
tsconfig: path.resolve(projectRoot, './src/tsconfig.json'),
47-
// resolveGlobs: false,
4847
module: "commonjs",
4948
target: "es5",
5049
useForkChecker: true,
@@ -67,7 +66,7 @@ export const getWebpackTestConfig = function(projectRoot: string) {
6766
],
6867
postLoaders: [
6968
{
70-
test: /\.(js|ts)$/, loader: 'istanbul-instrumenter-loader',
69+
test: /\.(js|ts)$/, loader: 'sourcemap-istanbul-instrumenter-loader',
7170
exclude: [
7271
/\.(e2e|spec)\.ts$/,
7372
/node_modules/

addon/ng2/utilities/ts-path-mappings-webpack-plugin.ts

-3
Original file line numberDiff line numberDiff line change
@@ -183,9 +183,6 @@ export class PathsPlugin implements ResolverPlugin {
183183
this.baseUrl
184184
);
185185

186-
console.log("CONFIG FILE AND BASE URL");
187-
console.log(this.configFilePath, this.absoluteBaseUrl);
188-
189186
this.mappings = [];
190187
let paths = this.options.paths || {};
191188
Object.keys(paths).forEach(alias => {

0 commit comments

Comments
 (0)