Skip to content

Commit bd1c6d9

Browse files
author
Bianca Del Carretto
committed
fix tests according to superclass roles matching (testing-library#448)
1 parent 5f9b024 commit bd1c6d9

File tree

2 files changed

+9
-4
lines changed

2 files changed

+9
-4
lines changed

src/__tests__/ariaAttributes.js

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,12 +63,17 @@ test('`selected: true` matches `aria-selected="true"` on supported roles', () =>
6363
).toEqual(['selected-native-columnheader', 'selected-columnheader'])
6464

6565
expect(getAllByRole('gridcell', {selected: true}).map(({id}) => id)).toEqual([
66+
'selected-rowheader',
67+
'selected-native-columnheader',
68+
'selected-columnheader',
69+
'selected-native-rowheader',
6670
'selected-gridcell',
6771
])
6872

6973
expect(getAllByRole('option', {selected: true}).map(({id}) => id)).toEqual([
7074
'selected-native-option',
7175
'selected-listbox-option',
76+
'selected-treeitem',
7277
])
7378

7479
expect(

src/__tests__/element-queries.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -521,11 +521,11 @@ test('queryAllByRole returns semantic html elements', () => {
521521
</form>
522522
`)
523523

524-
expect(queryAllByRole(/table/i)).toHaveLength(1)
525-
expect(queryAllByRole(/tabl/i, {exact: false})).toHaveLength(1)
524+
expect(queryAllByRole(/table/i)).toHaveLength(2)
525+
expect(queryAllByRole(/tabl/i, {exact: false})).toHaveLength(2)
526526
expect(queryAllByRole(/columnheader/i)).toHaveLength(1)
527527
expect(queryAllByRole(/rowheader/i)).toHaveLength(1)
528-
expect(queryAllByRole(/grid/i)).toHaveLength(1)
528+
expect(queryAllByRole(/grid/i)).toHaveLength(3)
529529
expect(queryAllByRole(/form/i)).toHaveLength(0)
530530
expect(queryAllByRole(/button/i)).toHaveLength(1)
531531
expect(queryAllByRole(/heading/i)).toHaveLength(6)
@@ -536,7 +536,7 @@ test('queryAllByRole returns semantic html elements', () => {
536536
expect(queryAllByRole(/radio/i)).toHaveLength(1)
537537
expect(queryAllByRole('row')).toHaveLength(3)
538538
expect(queryAllByRole(/rowgroup/i)).toHaveLength(2)
539-
expect(queryAllByRole(/(table)|(textbox)/i)).toHaveLength(3)
539+
expect(queryAllByRole(/(table)|(textbox)/i)).toHaveLength(4)
540540
expect(queryAllByRole(/img/i)).toHaveLength(1)
541541
expect(queryAllByRole('meter')).toHaveLength(1)
542542
expect(queryAllByRole('progressbar')).toHaveLength(0)

0 commit comments

Comments
 (0)