Skip to content

Commit a4722cf

Browse files
avasquez01James Bottomley
authored and
James Bottomley
committed
[SCSI] qla2xxx: Don't schedule the DPC routine to perform an issue-lip request.
As the driver depends on the DPC routine to handle bottom-half loop resynchronization in order to recover from the issue-lip request. The issue_lip call is sleeping context capable, so just issue the reset function there. Signed-off-by: Andrew Vasquez <[email protected]> Signed-off-by: James Bottomley <[email protected]>
1 parent da7429f commit a4722cf

File tree

3 files changed

+4
-3
lines changed

3 files changed

+4
-3
lines changed

drivers/scsi/qla2xxx/qla_attr.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -958,7 +958,7 @@ qla2x00_issue_lip(struct Scsi_Host *shost)
958958
{
959959
scsi_qla_host_t *ha = shost_priv(shost);
960960

961-
set_bit(LOOP_RESET_NEEDED, &ha->dpc_flags);
961+
qla2x00_loop_reset(ha);
962962
return 0;
963963
}
964964

drivers/scsi/qla2xxx/qla_gbl.h

+2
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,8 @@ extern int ql2xextended_error_logging;
6565
extern int ql2xqfullrampup;
6666
extern int num_hosts;
6767

68+
extern int qla2x00_loop_reset(scsi_qla_host_t *);
69+
6870
/*
6971
* Global Functions in qla_mid.c source file.
7072
*/

drivers/scsi/qla2xxx/qla_os.c

+1-2
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,6 @@ static int qla2xxx_eh_abort(struct scsi_cmnd *);
105105
static int qla2xxx_eh_device_reset(struct scsi_cmnd *);
106106
static int qla2xxx_eh_bus_reset(struct scsi_cmnd *);
107107
static int qla2xxx_eh_host_reset(struct scsi_cmnd *);
108-
static int qla2x00_loop_reset(scsi_qla_host_t *ha);
109108
static int qla2x00_device_reset(scsi_qla_host_t *, fc_port_t *);
110109

111110
static int qla2x00_change_queue_depth(struct scsi_device *, int);
@@ -1060,7 +1059,7 @@ qla2xxx_eh_host_reset(struct scsi_cmnd *cmd)
10601059
* Returns:
10611060
* 0 = success
10621061
*/
1063-
static int
1062+
int
10641063
qla2x00_loop_reset(scsi_qla_host_t *ha)
10651064
{
10661065
int ret;

0 commit comments

Comments
 (0)