Skip to content

Commit b9da06d

Browse files
Declan Kellydeclanvk
Declan Kelly
authored andcommitted
Increase MSRV to 1.64.0 and pin generated bindings rust version
**Description** - Increase MSRV to `1.64.0` and add README line stating MSRV. - Using the `bindgen::Builder::rust_target` function, set the rustc version required to `1.64.0` to access FFI types from `core`. **Motivation** Previous MSRV bump to `1.57.0` failed because `bindgen` generated bindings which required `1.64.0`. See issue rust-lang/rust-bindgen#2324 for slightly more context. **Testing Done** - `cargo +1.57.0 build` fails - `cargo +1.64.0 build` succeeds
1 parent 1017402 commit b9da06d

File tree

3 files changed

+5
-1
lines changed

3 files changed

+5
-1
lines changed

.github/workflows/rust-ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ jobs:
1717
- stable
1818
- beta
1919
- nightly
20-
- 1.57.0
20+
- 1.64.0
2121
os:
2222
- ubuntu-latest
2323
- windows-latest

README.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,8 @@ See [`examples/`](https://github.com/declanvk/reckoner/tree/master/examples) for
5757

5858
## Crates
5959

60+
The MSRV for both crates is `1.64.0`.
61+
6062
### `reckoner`
6163

6264
[![crates.io](https://img.shields.io/crates/d/reckoner)](https://crates.io/crates/reckoner) [![docs.rs](https://docs.rs/reckoner/badge.svg)](https://docs.rs/reckoner)

creachadair-imath-sys/build.rs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,8 @@ fn main() {
4242
.allowlist_function(FUNCTION_REG)
4343
.allowlist_type(TYPE_REG)
4444
.allowlist_var(VAR_REG)
45+
// Current MSRV is 1.64.0, see top-level README.md file
46+
.rust_target(bindgen::RustTarget::Stable_1_64)
4547
.generate()
4648
.expect("Unable to generate bindings");
4749

0 commit comments

Comments
 (0)