fix(create): Fix create when using db-migrate as module #496
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug introduced on db-migrate#485 Fixes: db-migrate#493
|
Awesome! And sry for the delay, I have little to no time currently due to some approaching events. |
|
Test fails as you call a new instance without providing a config object or other alternatives, so it searches for database.json. Here is an example where an empty config is passed over: |
|
@wzrdtales I made some changes and the tests are passing. Tell me if you prefer another way of doing it. |
|
This is totally fine :) |
wzrdtales
added a commit
that referenced
this pull request
Sep 13, 2017
fix(create): Fix create when using db-migrate as module
|
Was published as bug fix under |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug introduced on #485
Fixes: #493