Skip to content

Commit 9bcbaa0

Browse files
committed
fix(api): callback called twice
Revert the change to add the callback if it is undefined. Fixes #343
1 parent 0f35b9c commit 9bcbaa0

File tree

1 file changed

+0
-10
lines changed

1 file changed

+0
-10
lines changed

api.js

-10
Original file line numberDiff line numberDiff line change
@@ -680,8 +680,6 @@ function _assert(err, callback) {
680680

681681
function executeUp(internals, config, callback) {
682682

683-
var callback = callback || internals.onComplete;
684-
685683
if (!internals.argv.count) {
686684
internals.argv.count = Number.MAX_VALUE;
687685
}
@@ -711,8 +709,6 @@ function executeUp(internals, config, callback) {
711709

712710
function executeDown(internals, config, callback) {
713711

714-
var callback = callback || internals.onComplete;
715-
716712
if (!internals.argv.count) {
717713
log.info('Defaulting to running 1 down migration.');
718714
internals.argv.count = 1;
@@ -736,8 +732,6 @@ function executeDown(internals, config, callback) {
736732

737733
function executeDB(internals, config, callback) {
738734

739-
var callback = callback || internals.onComplete;
740-
741735
if (internals.argv._.length > 0) {
742736
internals.argv.dbname = internals.argv._.shift().toString();
743737
} else {
@@ -787,8 +781,6 @@ function executeDB(internals, config, callback) {
787781

788782
function executeSeed(internals, config, callback) {
789783

790-
var callback = callback || internals.onComplete;
791-
792784
if (internals.argv._.length > 0) {
793785
internals.argv.destination = internals.argv._.shift().toString();
794786
}
@@ -820,8 +812,6 @@ function executeSeed(internals, config, callback) {
820812

821813
function executeUndoSeed(internals, config, callback) {
822814

823-
var callback = callback || internals.onComplete;
824-
825815
if (!internals.argv.count) {
826816
log.info('Defaulting to running 1 down seed.');
827817
internals.argv.count = 1;

0 commit comments

Comments
 (0)