refactor(globals): remove several globals, this might break things

There are several things that are exposed as global. For example Migrator, Seeder, Class, or the async and dbm globals.

Most probably finally removing async and dbm which have been marked deprecated, will end up for some people in a breaking change. But we need to remove all those
globals, to not interfere with projects using db-migrate. DB-Migrate is not just a cli module anymore though. In this step we now also finally removed internals completely
from the API, and needed to adjust the onComplete callback to actually do this. This change could also lead to a breaking change and should thus be communicated

All in all this is a big clean up and also two not necessary functions were removed.

Author: wzrdtales

api.js

@@ -13,28 +13,22 @@ var pkginfo = require('pkginfo')(module, 'version'); // jshint ignore:line
 var dotenv = require('dotenv');
 var Promise = require('bluebird');
 
-
-//global declaration for detection like it's done in umigrate //deprecated
-global.dbm = require('./'); //deprecated
-global.async = require('async'); //deprecated
-
-var internals = {};
-
 function dbmigrate(isModule, options, callback) {
 
   this.internals = {
 
-    onComplete: internals.onComplete
+    onComplete: onComplete
   };
-  internals = this.internals;
+  var internals = this.internals;
 
   if (typeof(callback) === 'function')
     this.internals.onComplete = callback;
   else if (typeof(options) === 'function')
     this.internals.onComplete = options;
 
-  this.dataType = dbm.dataType;
-  this.version = dbm.version;
+  this.internals.dbm = require('./');
+  this.dataType = this.internals.dbm.dataType;
+  this.version = this.internals.dbm.version;
   dotenv.load({
     silent: true
   });
@@ -67,8 +61,7 @@ function dbmigrate(isModule, options, callback) {
   this.config = loadConfig( require('./lib/config.js'), this.internals );
 
   index.exportInternals(internals);
-  this.internals.dbm = dbm;
-  global.dbm = dbm; //deprecated
+
   this.internals.migrationOptions = {
     dbmigrate: this.internals.dbm,
     ignoreOnInit: this.internals.argv['ignore-on-init'],
@@ -112,7 +105,7 @@ dbmigrate.prototype = {
     return true;
   },
 
-  _internals: internals,
+  _internals: this.internals,
 
   /**
    * Add a configuration option to dbmigrate.
@@ -503,7 +496,7 @@ function setDefaultArgv(internals, isModule) {
   .argv;
 
   if (internals.argv.version) {
-    console.log(dbm.version);
+    console.log(internals.dbm.version);
     process.exit(0);
   }
 
@@ -652,7 +645,7 @@ function shouldIgnoreOnInitFiles( internals, config ) {
     'ignore-on-init'];
 }
 
-function shouldCreateCoffeeFile( intenrals, config ) {
+function shouldCreateCoffeeFile( internals, config ) {
   return internals.argv['coffee-file'] || config['coffee-file'];
 }
 
@@ -747,7 +740,7 @@ function executeUp(internals, config, callback) {
       log.verbose('migration table created');
 
       migrator.up(internals.argv, internals.onComplete.bind(this,
-        migrator, callback));
+        migrator, internals, callback));
     });
   });
 }
@@ -770,7 +763,7 @@ function executeDown(internals, config, callback) {
     migrator.driver.createMigrationsTable(function(err) {
       assert.ifError(err);
       migrator.down(internals.argv, internals.onComplete.bind(this,
-        migrator, callback));
+        migrator, internals, callback));
     });
   });
 }
@@ -842,13 +835,13 @@ function executeSeed(internals, config, callback) {
     if (internals.mode === 'static') {
 
       seeder.seed(internals.argv, internals.onComplete.bind(this, seeder,
-        callback));
+        internals, callback));
     } else {
       seeder.createSeedsTable(function(err) {
         if (_assert(err, callback)) {
 
           seeder.seed(internals.argv, internals.onComplete.bind(this,
-            seeder, callback));
+            seeder, internals, callback));
         }
       });
     }
@@ -884,16 +877,14 @@ function executeUndoSeed(internals, config, callback) {
         if (_assert(err, callback)) {
 
           seeder.down(internals.argv, internals.onComplete.bind(this,
-            seeder, callback));
+            seeder, internals, callback));
         }
       });
     }
   });
 }
 
-internals.onComplete = onComplete;
-
-function onComplete(migrator, callback, originalErr) {
+function onComplete(migrator, internals, callback, originalErr) {
 
   if (typeof(callback) !== 'function') {
     originalErr = originalErr || callback;

index.js

@@ -2,52 +2,6 @@ var pkginfo = require('pkginfo')(module, 'version'); // jshint ignore:line
 
 exports.dataType = require('db-migrate-shared').dataType;
 
-
-/**
- * Removes a module from the cache
- */
-uncache = function (moduleName) {
-    // Run over the cache looking for the files
-    // loaded by the specified module name
-    searchCache(moduleName, function (mod) {
-        delete require.cache[mod.id];
-    });
-
-    // Remove cached paths to the module.
-    // Thanks to @bentael for pointing this out.
-    Object.keys(module.constructor._pathCache).forEach(function(cacheKey) {
-        if (cacheKey.indexOf(moduleName)>0) {
-            delete module.constructor._pathCache[cacheKey];
-        }
-    });
-};
-
-/**
- * Runs over the cache to search for all the cached
- * files
- */
-searchCache = function (moduleName, callback) {
-    // Resolve the module identified by the specified name
-    var mod = require.resolve(moduleName);
-
-    // Check if the module has been resolved and found within
-    // the cache
-    if (mod && ((mod = require.cache[mod]) !== undefined)) {
-        // Recursively go over the results
-        (function run(mod) {
-            // Go over each of the module's children and
-            // run over it
-            mod.children.forEach(function (child) {
-                run(child);
-            });
-
-            // Call the specified callback providing the
-            // found module
-            callback(mod);
-        })(mod);
-    }
-};
-
 module.exports.getInstance = function(isModule, options, callback) {
 
   delete require.cache[require.resolve('./api.js')];

lib/class.js

@@ -6,10 +6,10 @@
 var initializing = false, fnTest = /xyz/.test(function(){xyz;}) ? /\b_super\b/ : /.*/;
 
 // The base Class implementation (does nothing)
-Class = function(){};
+var Class = function(){};
 
 // Create a new Class that inherits from this class
-Class.extend = function(prop) {
+Class.extend = function ext(prop) {
   var _super = this.prototype;
 
   // Instantiate a base class (but only create the instance,
@@ -56,7 +56,7 @@ Class.extend = function(prop) {
   Class.prototype.constructor = Class;
 
   // And make this class extendable
-  Class.extend = arguments.callee;
+  Class.extend = ext;
 
   return Class;
 };

lib/migrator.js

@@ -51,7 +51,7 @@ SeedLink.prototype = {
   }
 };
 
-Migrator = function(driver, migrationsDir, empty, intern) {
+var Migrator = function(driver, migrationsDir, empty, intern) {
   this.driver = dbmUtil.reduceToInterface( driver, MigratorInterface );
   this._driver = driver;
   this.migrationsDir = migrationsDir;

lib/seeder.js

@@ -94,7 +94,7 @@ MigrationLink.prototype = {
   }
 };
 
-Seeder = function (driver, seedsDir, versionControlled, intern) {
+var Seeder = function (driver, seedsDir, versionControlled, intern) {
   SeederInterface.extending = intern.interfaces.SeederInterface;
   this.driver = dbmUtil.reduceToInterface( driver, SeederInterface );
   this._driver = driver;