From df4efd4762b36f9ff4f4510840b075e2d5d96514 Mon Sep 17 00:00:00 2001 From: Dave Hirschfeld Date: Fri, 2 Feb 2024 15:24:44 +1100 Subject: [PATCH 1/2] Enable `delta.feature.allowColumnDefaults` for all tables --- src/databricks/sqlalchemy/_ddl.py | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/databricks/sqlalchemy/_ddl.py b/src/databricks/sqlalchemy/_ddl.py index 667d46da..7ed0647f 100644 --- a/src/databricks/sqlalchemy/_ddl.py +++ b/src/databricks/sqlalchemy/_ddl.py @@ -16,13 +16,15 @@ def __init__(self, dialect): class DatabricksDDLCompiler(compiler.DDLCompiler): def post_create_table(self, table): - post = " USING DELTA" + post = [" USING DELTA"] if table.comment: comment = self.sql_compiler.render_literal_value( table.comment, sqltypes.String() ) - post += " COMMENT " + comment - return post + post.append("COMMENT " + comment) + + post.append("TBLPROPERTIES('delta.feature.allowColumnDefaults' = 'enabled')") + return '\n'.join(post) def visit_unique_constraint(self, constraint, **kw): logger.warning("Databricks does not support unique constraints") From daf92bba5e9ee79167e09a6379584f27f3241092 Mon Sep 17 00:00:00 2001 From: Levko Kravets Date: Thu, 30 May 2024 18:27:54 +0300 Subject: [PATCH 2/2] Code style Signed-off-by: Levko Kravets --- src/databricks/sqlalchemy/_ddl.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/databricks/sqlalchemy/_ddl.py b/src/databricks/sqlalchemy/_ddl.py index 7ed0647f..d5d0bf87 100644 --- a/src/databricks/sqlalchemy/_ddl.py +++ b/src/databricks/sqlalchemy/_ddl.py @@ -24,7 +24,7 @@ def post_create_table(self, table): post.append("COMMENT " + comment) post.append("TBLPROPERTIES('delta.feature.allowColumnDefaults' = 'enabled')") - return '\n'.join(post) + return "\n".join(post) def visit_unique_constraint(self, constraint, **kw): logger.warning("Databricks does not support unique constraints")