Skip to content

Write operation ids as hex instead of bytes #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
susodapop opened this issue Jun 28, 2023 · 1 comment · Fixed by #170
Closed

Write operation ids as hex instead of bytes #163

susodapop opened this issue Jun 28, 2023 · 1 comment · Fixed by #170

Comments

@susodapop
Copy link
Contributor

Thrift responses include operationId and sessionId guids as byte arrays. We print these in our logs and include them in ServerOperationError responses. But they aren't human readable. We can use Python's built-in UUID library to convert them into human-readable hex strings. In the case of query ids, these can be directly tied back to Databricks Query History API responses.

@susodapop
Copy link
Contributor Author

I implemented this is one spot here: #159 with the get_session_id_hex method. But we're still writing out bytes-like GUIDs in numerous other places in the code base such as here, here, and here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant