Skip to content

Stop emitting unredacted thrift responses by default #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
susodapop opened this issue Jun 21, 2023 · 1 comment · Fixed by #153
Closed

Stop emitting unredacted thrift responses by default #152

susodapop opened this issue Jun 21, 2023 · 1 comment · Fixed by #153

Comments

@susodapop
Copy link
Contributor

Over in dbt-databricks we want to wire-in pysql logs but have found that the complete content of every thrift response is included in the outputted logs. These are tough to redact with a regex because thrift doesn't implement a deterministic kind of serialisation. Instead, the raw bytes are interpreted as utf-8 strings. Rather than fix this in dbt-databricks, we should modify pysql to separate the unredacted logs under a separate logger that most tools can simply ignore.

@susodapop
Copy link
Contributor Author

PR incoming with this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant