Skip to content

Commit dda54da

Browse files
author
Jesse Whitehouse
committed
Skip socket_timeout test since setting timeout == 0 no longer causes
issues with urllib3 Signed-off-by: Jesse Whitehouse <[email protected]>
1 parent ae44b12 commit dda54da

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

tests/e2e/driver_tests.py

+1
Original file line numberDiff line numberDiff line change
@@ -458,6 +458,7 @@ def test_temp_view_fetch(self):
458458
# once what is being returned has stabilised
459459

460460
@skipIf(pysql_has_version('<', '2'), 'requires pysql v2')
461+
@skipIf(True, "Unclear the purpose of this test since urllib3 does not complain when timeout == 0")
461462
def test_socket_timeout(self):
462463
# We we expect to see a BlockingIO error when the socket is opened
463464
# in non-blocking mode, since no poll is done before the read

0 commit comments

Comments
 (0)