Skip to content

Commit b8e1bbd

Browse files
expect session_id in protocol version getter
Signed-off-by: varun-edachali-dbx <[email protected]>
1 parent 3d75d6c commit b8e1bbd

File tree

1 file changed

+3
-16
lines changed

1 file changed

+3
-16
lines changed

src/databricks/sql/client.py

Lines changed: 3 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@
4747
from databricks.sql.auth.auth import get_python_sql_connector_auth_provider
4848
from databricks.sql.experimental.oauth_persistence import OAuthPersistence
4949
from databricks.sql.session import Session
50-
from databricks.sql.backend.types import CommandId, BackendType
50+
from databricks.sql.backend.types import CommandId, BackendType, SessionId
5151

5252
from databricks.sql.thrift_api.TCLIService.ttypes import (
5353
TSparkParameter,
@@ -325,9 +325,9 @@ def protocol_version(self):
325325
return self.session.protocol_version
326326

327327
@staticmethod
328-
def get_protocol_version(openSessionResp):
328+
def get_protocol_version(session_id: SessionId):
329329
"""Delegate to Session class static method"""
330-
return Session.get_protocol_version(openSessionResp)
330+
return Session.get_protocol_version(session_id)
331331

332332
@property
333333
def open(self) -> bool:
@@ -868,19 +868,6 @@ def is_query_pending(self):
868868
ttypes.TOperationState.PENDING_STATE,
869869
]
870870

871-
def is_query_pending(self):
872-
"""
873-
Checks whether the async executing query is in pending state or not
874-
875-
:return:
876-
"""
877-
operation_state = self.get_query_state()
878-
879-
return not operation_state or operation_state in [
880-
ttypes.TOperationState.RUNNING_STATE,
881-
ttypes.TOperationState.PENDING_STATE,
882-
]
883-
884871
def get_async_execution_result(self):
885872
"""
886873

0 commit comments

Comments
 (0)