Update src/databricks/sql/utils.py

wyattscarpenter · kravets-levko · wyattscarpenter · commit b678e9b898e7 · 2024-07-02T01:02:50.000-04:00
"self.download_manager is unconditionally used later, so must be created. Looks this part of code is totally not covered with tests 🤔"

Co-authored-by: Levko Kravets &lt;levko.ne@gmail.com&gt;
Signed-off-by: wyattscarpenter &lt;wyattscarpenter@gmail.com&gt;
diff --git a/src/databricks/sql/utils.py b/src/databricks/sql/utils.py
@@ -168,10 +168,10 @@ def __init__(
                         result_link.startRowOffset, result_link.rowCount
                     )
                 )
-            self.download_manager = ResultFileDownloadManager(
-                self.max_download_threads, self.lz4_compressed
-            )
-            self.download_manager.add_file_links(result_links)
+        self.download_manager = ResultFileDownloadManager(
+            self.max_download_threads, self.lz4_compressed
+        )
+        self.download_manager.add_file_links(result_links or [])
 
         self.table = self._create_next_table()
         self.table_row_index = 0

Original file line number	Diff line number	Diff line change
`@@ -168,10 +168,10 @@ def __init__(`
`168`	`168`	`result_link.startRowOffset, result_link.rowCount`
`169`	`169`	`)`
`170`	`170`	`)`
`171`		`- self.download_manager = ResultFileDownloadManager(`
`172`		`- self.max_download_threads, self.lz4_compressed`
`173`		`- )`
`174`		`- self.download_manager.add_file_links(result_links)`
	`171`	`+ self.download_manager = ResultFileDownloadManager(`
	`172`	`+ self.max_download_threads, self.lz4_compressed`
	`173`	`+ )`
	`174`	`+ self.download_manager.add_file_links(result_links or [])`
`175`	`175`
`176`	`176`	`self.table = self._create_next_table()`
`177`	`177`	`self.table_row_index = 0`