Fix componentreflection test (#328)

Jesse · web-flow · commit a7f4773d92b7 · 2024-01-23T15:57:15.000-05:00
Fix: this allows component reflection test to pass

Databricks returns an empty string in the REMARKS column rather than a
`NoneType`.

Signed-off-by: Jesse Whitehouse &lt;jesse.whitehouse@databricks.com&gt;
diff --git a/src/databricks/sqlalchemy/_parse.py b/src/databricks/sqlalchemy/_parse.py
@@ -354,7 +354,7 @@ def parse_column_info_from_tgetcolumnsresponse(thrift_resp_row) -> ReflectedColu
         "type": final_col_type,
         "nullable": bool(thrift_resp_row.NULLABLE),
         "default": thrift_resp_row.COLUMN_DEF,
-        "comment": thrift_resp_row.REMARKS,
+        "comment": thrift_resp_row.REMARKS or None,
     }
 
     # TODO: figure out how to return sqlalchemy.interfaces in a way that mypy respects

Original file line number	Diff line number	Diff line change
`@@ -354,7 +354,7 @@ def parse_column_info_from_tgetcolumnsresponse(thrift_resp_row) -> ReflectedColu`
`354`	`354`	`"type": final_col_type,`
`355`	`355`	`"nullable": bool(thrift_resp_row.NULLABLE),`
`356`	`356`	`"default": thrift_resp_row.COLUMN_DEF,`
`357`		`- "comment": thrift_resp_row.REMARKS,`
	`357`	`+ "comment": thrift_resp_row.REMARKS or None,`
`358`	`358`	`}`
`359`	`359`
`360`	`360`	`# TODO: figure out how to return sqlalchemy.interfaces in a way that mypy respects`