Skip to content

Commit 82e35dc

Browse files
author
Jesse Whitehouse
committed
Refactor so we can unit test inject_parameters
Signed-off-by: Jesse Whitehouse <[email protected]>
1 parent d024317 commit 82e35dc

File tree

2 files changed

+9
-3
lines changed

2 files changed

+9
-3
lines changed

src/databricks/sql/client.py

+4-2
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
from databricks.sql import *
1313
from databricks.sql.exc import OperationalError
1414
from databricks.sql.thrift_backend import ThriftBackend
15-
from databricks.sql.utils import ExecuteResponse, ParamEscaper
15+
from databricks.sql.utils import ExecuteResponse, ParamEscaper, inject_parameters
1616
from databricks.sql.types import Row
1717

1818
logger = logging.getLogger(__name__)
@@ -260,7 +260,9 @@ def execute(
260260
:returns self
261261
"""
262262
if parameters is not None:
263-
operation = operation % self.escaper.escape_args(parameters)
263+
operation = inject_parameters(
264+
operation, self.escaper.escape_args(parameters)
265+
)
264266

265267
self._check_not_closed()
266268
self._close_and_clear_active_result_set()

src/databricks/sql/utils.py

+5-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
from collections.abc import Iterable
33
import datetime
44
from enum import Enum
5-
5+
from typing import Dict
66
import pyarrow
77

88

@@ -172,3 +172,7 @@ def escape_item(self, item):
172172
return self.escape_datetime(item, self._DATE_FORMAT)
173173
else:
174174
raise exc.ProgrammingError("Unsupported object {}".format(item))
175+
176+
177+
def inject_parameters(operation: str, parameters: Dict[str, str]):
178+
return operation % parameters

0 commit comments

Comments
 (0)