rename info to properties

Signed-off-by: varun-edachali-dbx <[email protected]>

Author: varun-edachali-dbx

src/databricks/sql/backend/thrift_backend.py

@@ -5,11 +5,9 @@
 import time
 import uuid
 import threading
-from typing import List, Union, Any, TYPE_CHECKING
-
-if TYPE_CHECKING:
-    from databricks.sql.client import Cursor
+from typing import List, Union, Any
 
+from databricks.sql.client import Cursor
 from databricks.sql.thrift_api.TCLIService.ttypes import TOperationState
 from databricks.sql.backend.types import (
     SessionId,
@@ -586,12 +584,12 @@ def open_session(self, session_configuration, catalog, schema) -> SessionId:
             response = self.make_request(self._client.OpenSession, open_session_req)
             self._check_initial_namespace(catalog, schema, response)
             self._check_protocol_version(response)
-            info = (
+            properties = (
                 {"serverProtocolVersion": response.serverProtocolVersion}
                 if response.serverProtocolVersion
                 else {}
             )
-            return SessionId.from_thrift_handle(response.sessionHandle, info)
+            return SessionId.from_thrift_handle(response.sessionHandle, properties)
         except:
             self._transport.close()
             raise
@@ -815,7 +813,7 @@ def _results_message_to_execute_response(self, resp, operation_state):
             arrow_schema_bytes=schema_bytes,
         )
 
-    def get_execution_result(self, command_id: CommandId, cursor: "Cursor"):
+    def get_execution_result(self, command_id: CommandId, cursor):
         thrift_handle = command_id.to_thrift_handle()
         if not thrift_handle:
             raise ValueError("Not a valid Thrift command ID")
@@ -931,7 +929,7 @@ def execute_command(
         max_rows: int,
         max_bytes: int,
         lz4_compression: bool,
-        cursor: "Cursor",
+        cursor: Cursor,
         use_cloud_fetch=True,
         parameters=[],
         async_op=False,
@@ -989,7 +987,7 @@ def get_catalogs(
         session_id: SessionId,
         max_rows: int,
         max_bytes: int,
-        cursor: "Cursor",
+        cursor: Cursor,
     ) -> ExecuteResponse:
         thrift_handle = session_id.to_thrift_handle()
         if not thrift_handle:
@@ -1009,7 +1007,7 @@ def get_schemas(
         session_id: SessionId,
         max_rows: int,
         max_bytes: int,
-        cursor: "Cursor",
+        cursor: Cursor,
         catalog_name=None,
         schema_name=None,
     ) -> ExecuteResponse:
@@ -1033,7 +1031,7 @@ def get_tables(
         session_id: SessionId,
         max_rows: int,
         max_bytes: int,
-        cursor: "Cursor",
+        cursor: Cursor,
         catalog_name=None,
         schema_name=None,
         table_name=None,
@@ -1061,7 +1059,7 @@ def get_columns(
         session_id: SessionId,
         max_rows: int,
         max_bytes: int,
-        cursor: "Cursor",
+        cursor: Cursor,
         catalog_name=None,
         schema_name=None,
         table_name=None,

src/databricks/sql/backend/types.py

@@ -43,7 +43,7 @@ def __init__(
         backend_type: BackendType,
         guid: Any,
         secret: Optional[Any] = None,
-        info: Optional[Dict[str, Any]] = None,
+        properties: Optional[Dict[str, Any]] = None,
     ):
         """
         Initialize a SessionId.
@@ -57,7 +57,7 @@ def __init__(
         self.backend_type = backend_type
         self.guid = guid
         self.secret = secret
-        self.info = info or {}
+        self.properties = properties or {}
 
     def __str__(self) -> str:
         """
@@ -76,7 +76,7 @@ def __str__(self) -> str:
         return str(self.guid)
 
     @classmethod
-    def from_thrift_handle(cls, session_handle, info: Optional[Dict[str, Any]] = None):
+    def from_thrift_handle(cls, session_handle, properties: Optional[Dict[str, Any]] = None):
         """
         Create a SessionId from a Thrift session handle.
 
@@ -93,15 +93,15 @@ def from_thrift_handle(cls, session_handle, info: Optional[Dict[str, Any]] = Non
         secret_bytes = session_handle.sessionId.secret
 
         if session_handle.serverProtocolVersion is not None:
-            if info is None:
-                info = {}
-            info["serverProtocolVersion"] = session_handle.serverProtocolVersion
+            if properties is None:
+                properties = {}
+            properties["serverProtocolVersion"] = session_handle.serverProtocolVersion
 
-        return cls(BackendType.THRIFT, guid_bytes, secret_bytes, info)
+        return cls(BackendType.THRIFT, guid_bytes, secret_bytes, properties)
 
     @classmethod
     def from_sea_session_id(
-        cls, session_id: str, info: Optional[Dict[str, Any]] = None
+        cls, session_id: str, properties: Optional[Dict[str, Any]] = None
     ):
         """
         Create a SessionId from a SEA session ID.
@@ -112,7 +112,7 @@ def from_sea_session_id(
         Returns:
             A SessionId instance
         """
-        return cls(BackendType.SEA, session_id, info=info)
+        return cls(BackendType.SEA, session_id, properties=properties)
 
     def to_thrift_handle(self):
         """
@@ -127,7 +127,7 @@ def to_thrift_handle(self):
         from databricks.sql.thrift_api.TCLIService import ttypes
 
         handle_identifier = ttypes.THandleIdentifier(guid=self.guid, secret=self.secret)
-        server_protocol_version = self.info.get("serverProtocolVersion")
+        server_protocol_version = self.properties.get("serverProtocolVersion")
         return ttypes.TSessionHandle(
             sessionId=handle_identifier, serverProtocolVersion=server_protocol_version
         )
@@ -169,7 +169,7 @@ def get_protocol_version(self):
         Returns:
             The server protocol version or None if this is not a Thrift session ID
         """
-        return self.info.get("serverProtocolVersion")
+        return self.properties.get("serverProtocolVersion")
 
 
 class CommandId:

tests/unit/test_parameters.py

@@ -64,12 +64,12 @@ class TestSessionHandleChecks(object):
         ],
     )
     def test_get_protocol_version_fallback_behavior(self, test_input, expected):
-        info = (
+        properties = (
             {"serverProtocolVersion": test_input.serverProtocolVersion}
             if test_input.serverProtocolVersion
             else {}
         )
-        session_id = SessionId.from_thrift_handle(test_input.sessionHandle, info)
+        session_id = SessionId.from_thrift_handle(test_input.sessionHandle, properties)
         assert Connection.get_protocol_version(session_id) == expected
 
     @pytest.mark.parametrize(