Timeout is never None

Signed-off-by: Matthew Kim <[email protected]>

Author: mattdeekay

src/databricks/sql/cloudfetch/downloader.py

@@ -51,8 +51,7 @@ def is_file_download_successful(self) -> bool:
 
         This function will block until a file download finishes or until a timeout.
         """
-        timeout = self.settings.download_timeout
-        timeout = timeout if timeout and timeout > 0 else None
+        timeout = self.settings.download_timeout if self.settings.download_timeout > 0 else None
         try:
             if not self.is_download_finished.wait(timeout=timeout):
                 self.is_download_timedout = True

tests/unit/test_downloader.py

@@ -136,7 +136,7 @@ def test_download_timeout(self, mock_time, mock_session):
 
     @patch("threading.Event.wait", return_value=True)
     def test_is_file_download_successful_has_finished(self, mock_wait):
-        for timeout in [None, 0, 1]:
+        for timeout in [0, 1]:
             with self.subTest(timeout=timeout):
                 settings = Mock(download_timeout=timeout)
                 result_link = Mock()