From cc65665ec40d1b6cc36bda298dfa7f78c5c196cb Mon Sep 17 00:00:00 2001 From: "Thomas J. Fan" Date: Thu, 26 Aug 2021 22:46:46 -0400 Subject: [PATCH] ENH Adds column name validation to pandas implementation --- protocol/pandas_implementation.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/protocol/pandas_implementation.py b/protocol/pandas_implementation.py index 786bfbd2..385da479 100644 --- a/protocol/pandas_implementation.py +++ b/protocol/pandas_implementation.py @@ -66,6 +66,10 @@ def _from_dataframe(df : DataFrameObject) -> pd.DataFrame: _k = _DtypeKind _buffers = [] # hold on to buffers, keeps memory alive for name in df.column_names(): + if not isinstance(name, str): + raise ValueError(f"Column {name} is not a string") + if name in columns: + raise ValueError(f"Column {name} is not unique") col = df.get_column_by_name(name) if col.dtype[0] in (_k.INT, _k.UINT, _k.FLOAT, _k.BOOL): # Simple numerical or bool dtype, turn into numpy array