From aa52871e77c138a55fdf81c8f45e20ba195b650d Mon Sep 17 00:00:00 2001 From: MarcoGorelli <33491632+MarcoGorelli@users.noreply.github.com> Date: Mon, 4 Sep 2023 16:07:20 +0200 Subject: [PATCH 1/2] get_column_names -> column_names property --- spec/API_specification/dataframe_api/dataframe_object.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/spec/API_specification/dataframe_api/dataframe_object.py b/spec/API_specification/dataframe_api/dataframe_object.py index 7dac2966..878afa9b 100644 --- a/spec/API_specification/dataframe_api/dataframe_object.py +++ b/spec/API_specification/dataframe_api/dataframe_object.py @@ -268,7 +268,8 @@ def rename_columns(self, mapping: Mapping[str, str]) -> DataFrame: """ ... - def get_column_names(self) -> list[str]: + @property + def column_names(self) -> list[str]: """ Get column names. From 52cb82a4a9a05327fed372340c4f10d9e09e7c8c Mon Sep 17 00:00:00 2001 From: MarcoGorelli <33491632+MarcoGorelli@users.noreply.github.com> Date: Wed, 6 Sep 2023 14:57:21 +0200 Subject: [PATCH 2/2] get_column_names -> column_names --- spec/API_specification/dataframe_api/dataframe_object.py | 2 +- spec/purpose_and_scope.md | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/spec/API_specification/dataframe_api/dataframe_object.py b/spec/API_specification/dataframe_api/dataframe_object.py index 878afa9b..07f7cada 100644 --- a/spec/API_specification/dataframe_api/dataframe_object.py +++ b/spec/API_specification/dataframe_api/dataframe_object.py @@ -199,7 +199,7 @@ def insert_column(self, column: Column[Any]) -> DataFrame: .. code-block:: python new_column = df.get_column_by_name('a') + 1 - new_columns_names = ['a_plus_1'] + df.get_column_names() + new_columns_names = ['a_plus_1'] + df.column_names df = df.insert_column(new_column.rename('a_plus_1')) df = df.get_columns_by_name(new_column_names) diff --git a/spec/purpose_and_scope.md b/spec/purpose_and_scope.md index 199d1a74..d6fbc808 100644 --- a/spec/purpose_and_scope.md +++ b/spec/purpose_and_scope.md @@ -284,17 +284,17 @@ df_pandas = pl.read_parquet('iris.parquet') df_polars = pl.scan_parquet('iris.parquet') def my_dataframe_agnostic_function(df): - df = df.__dataframe_consortium_standard__(api_version='2023.08-beta') + df = df.__dataframe_consortium_standard__() mask = df.get_column_by_name('species') != 'setosa' df = df.get_rows_by_mask(mask) - for column_name in df.get_column_names(): + for column_name in df.column_names if column_name == 'species': continue new_column = df.get_column_by_name(column_name) new_column = (new_column - new_column.mean()) / new_column.std() - df = df.insert(loc=len(df.get_column_names()), label=f'{column_name}_scaled', value=new_column) + df = df.insert_column(new_column.rename(f'{column_name}_scaled')) return df.dataframe